Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resize of block devices #5

Closed
wants to merge 1 commit into from

Conversation

bertinatto
Copy link
Member

@bertinatto bertinatto commented Apr 19, 2021

The test:

External Storage [Driver: disk.csi.azure.com] [Testpattern: Dynamic PV (default fs)(allowExpansion)] volume-expand Verify if offline PVC expansion works

Fails with:

  Type     Reason                  Age                  From                                                        Message
  ----     ------                  ----                 ----                                                        -------
  Normal   Scheduled               <unknown>                                                                        Successfully assigned e2e-volume-expand-8235/pod-1b9dd0fb-a7de-4f9d-8f37-0796e96a9fd9 to ci-ln-pcprg12-002ac-znwvd-worker-centralus3-gdltz
  Normal   SuccessfulAttachVolume  2m35s                attachdetach-controller                                     AttachVolume.Attach succeeded for volume "pvc-b884879e-bbd7-4853-89a4-1328f58d50e2"
  Warning  FailedMount             38s                  kubelet, ci-ln-pcprg12-002ac-znwvd-worker-centralus3-gdltz  Unable to attach or mount volumes: unmounted volumes=[volume1], unattached volumes=[volume1 default-token-sjszb]: timed out waiting for the condition
  Warning  FailedMount             24s (x9 over 2m32s)  kubelet, ci-ln-pcprg12-002ac-znwvd-worker-centralus3-gdltz  MountVolume.MountDevice failed while expanding volume for volume "pvc-b884879e-bbd7-4853-89a4-1328f58d50e2" : Expander.NodeExpand failed to expand the volume : rpc error: code = Internal desc = Could not get size of block volume at path /var/lib/kubelet/plugins/kubernetes.io/csi/pv/pvc-b884879e-bbd7-4853-89a4-1328f58d50e2/globalmount: error when getting size of block volume at path /var/lib/kubelet/plugins/kubernetes.io/csi/pv/pvc-b884879e-bbd7-4853-89a4-1328f58d50e2/globalmount: output: , err: exit status 1

Apparently the CSI driver isn't recognizing that the volume is a block device.

Checking if this patch fixes failures in e2e-azure-csi job. I'll create an upstream patch if this fixes the issue.

CC @openshift/storage

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2021
@bertinatto
Copy link
Member Author

/hold
Checking if this patch fixes failures in e2e-azure-csi job.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2021
@bertinatto bertinatto changed the title Fix resize Fix resize of block devices Apr 19, 2021

return (st.Mode & unix.S_IFMT) == unix.S_IFBLK, nil
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, this won't work on Windows...

@openshift-ci
Copy link

openshift-ci bot commented Apr 19, 2021

@bertinatto: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-azure-csi b7b93a5 link /test e2e-azure-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 27, 2021
@openshift-ci
Copy link

openshift-ci bot commented Apr 27, 2021

@bertinatto: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 26, 2021
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 25, 2021
@bertinatto bertinatto closed this Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants