OCPBUGS-22941: UPSTREAM: 1755: fix: detach disk failure when there is throttling

[bertinatto]

CC @openshift/storage

Please review carefully because this wasn't a clean pick. kubernetes-sigs/cloud-provider-azure#3482 is the original patch.

[openshift-ci-robot]

@bertinatto: This pull request references Jira Issue OCPBUGS-22941, which is invalid:

• expected dependent Jira Issue OCPBUGS-23216 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead
• expected dependent Jira Issue OCPBUGS-23216 to target a version in 4.13.0, 4.13.z, but it targets "4.13" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

CC @openshift/storage

Please review carefully because this wasn't a clean pick. kubernetes-sigs/cloud-provider-azure#3482 is the original patch.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bertinatto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bertinatto]

/jira refresh

[openshift-ci-robot]

@bertinatto: This pull request references Jira Issue OCPBUGS-22941, which is invalid:

• expected dependent Jira Issue OCPBUGS-23216 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead
• expected dependent Jira Issue OCPBUGS-23216 to target a version in 4.13.0, 4.13.z, but it targets "4.13" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jsafrane]

/lgtm
/override ci/prow/verify-deps

[jsafrane]

/label backport-risk-assessed

[openshift-ci]

@jsafrane: Overrode contexts on behalf of jsafrane: ci/prow/verify-deps

In response to this:

/lgtm
/override ci/prow/verify-deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@bertinatto: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-deps	5b7baf7	link	true	/test verify-deps

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sdodson]

Looks like a legitimate test failure.

[gnufied]

So this PR modifies vendor directly and hence it is indeed a legitimate failure, but we were kinda options here, so we are sort of doing this as last resort. Any direct modification to vendor has danger of getting wiped away if someone does go mod download && go mod vendor, but hopefully we won't be doing this in 4.12..

[gnufied]

/jira refresh

[openshift-ci-robot]

@gnufied: This pull request references Jira Issue OCPBUGS-22941, which is invalid:

• expected dependent Jira Issue OCPBUGS-23216 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[duanwei33]

/label cherry-pick-approved

[duanwei33]

/jira refresh

[openshift-ci-robot]

@duanwei33: This pull request references Jira Issue OCPBUGS-22941, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.12.z) matches configured target version for branch (4.12.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-23216 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-23216 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@bertinatto: Jira Issue OCPBUGS-22941: All pull requests linked via external trackers have merged:

• openshift/azure-disk-csi-driver#62

Jira Issue OCPBUGS-22941 has been moved to the MODIFIED state.

In response to this:

CC @openshift/storage

Please review carefully because this wasn't a clean pick. kubernetes-sigs/cloud-provider-azure#3482 is the original patch.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-azure-disk-csi-driver-container-v4.12.0-202311231231.p0.ga930c89.assembly.stream for distgit ose-azure-disk-csi-driver.
All builds following this will include this PR.

[sdodson]

/jira refresh

[openshift-ci-robot]

@sdodson: Jira Issue OCPBUGS-22941 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.