Bug 1912701: Handle dual-stack configuration in inspection data #118
Conversation
Currently we assume only an ipv4 *or* an ipv6 IP exists in the inspection data, but it's valid for both to exist in a dual-stack scenario. To avoid changing the BMH API, in this case we create an additional nic entry in the list, which will contain each IP but otherwise the same data. Fixes: metal3-io#458
openshift-ci-robot
added
bugzilla/severity-high
|
@hardys: This pull request references Bugzilla bug 1912701, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, hardys The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@hardys: All pull requests linked via external trackers have merged: Bugzilla bug 1912701 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a cherry-pick of metal3-io#758
Currently we assume only an ipv4 or an ipv6 IP exists in the
inspection data, but it's valid for both to exist in a dual-stack
scenario.
To avoid changing the BMH API, in this case we create an additional
nic entry in the list, which will contain each IP but otherwise
the same data.