Bug 1910352: Fail registration when boot MAC address conflicts #131
Conversation
When registering a new host, we check if its bootMACAddress conflicts with any existing Ironic nodes. This procedure queries Ironic ports, and if a port is found, we use the port's NodeUUID to find the conflicting node. However, we are using `ports.List()` which only returns minimal resources by default; e.g. any returned ports will have their NodeUUID property set to an empty string. We are now explicitly asking for Ironic to include the `node_uuid` field. We also adjust the mock test mechanism to account for this. (cherry picked from commit 51c157d) Signed-off-by: Honza Pokorny <honza@redhat.com>
If we can't find a node by name, and have to resort to using MAC address lookup, we can't accept a node that has a name. In that scenario, we have detected a MAC address collision, and human intervention is required. We signal this by returning an `operationFailed` provisioning result with the offending MAC address in the error message. (cherry picked from commit 1dc7f4c) Signed-off-by: Honza Pokorny <honza@redhat.com>
openshift-ci-robot
added
bugzilla/severity-medium
|
@honza: This pull request references Bugzilla bug 1910352, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
|
/bugzilla refresh |
|
@honza: This pull request references Bugzilla bug 1910352, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@honza: This pull request references Bugzilla bug 1910352, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/valid-bug
|
@honza: This pull request references Bugzilla bug 1910352, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (prabinov@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-metal-ipi-ovn-dualstack |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: honza, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ecordell
added
the
cherry-pick-approved
|
/test e2e-metal-ipi-ovn-ipv6 |
|
@honza: All pull requests linked via external trackers have merged: Bugzilla bug 1910352 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.