Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1956607: Fix resources added to 0000_30_baremetal-operator_01_baremetalhost.crd.yaml #146

Merged
merged 1 commit into from May 14, 2021

Conversation

sadasu
Copy link

@sadasu sadasu commented May 6, 2021

The manifest presented to CVO should contain just the BMH CRD and not other manifests defined in capm3.yaml.

@openshift-ci
Copy link

openshift-ci bot commented May 6, 2021

@sadasu: An error was encountered querying GitHub for users with public email (augol@redhat.com) for bug 1956607 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. Post "http://ghproxy/graphql": failed to get installation id for org : the github app is not installed in organization

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1956607: Add annotations to all resources added to capm3.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from asalkeld and honza May 6, 2021 15:00
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2021
@sadasu
Copy link
Author

sadasu commented May 6, 2021

/retest

@stbenjam
Copy link
Member

stbenjam commented May 7, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label May 7, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 7, 2021

@stbenjam: This pull request references Bugzilla bug 1956607, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (augol@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 7, 2021
@stbenjam
Copy link
Member

stbenjam commented May 7, 2021

/retest

@stbenjam
Copy link
Member

The errors in CI look related since it's failing the same on both jobs:

 INFO[2021-05-07T16:53:54Z] level=debug msg=Still waiting for the cluster to initialize: Could not update role "baremetal-operator-system/baremetal-operator-leader-election-role" (135 of 705): resource may have been deleted 
INFO[2021-05-07T16:53:54Z] level=debug msg=Still waiting for the cluster to initialize: Could not update role "baremetal-operator-system/baremetal-operator-leader-election-role" (135 of 705): resource may have been deleted 

@sadasu
Copy link
Author

sadasu commented May 10, 2021

/test e2e-metal-ipi-ovn-ipv6

@sadasu
Copy link
Author

sadasu commented May 10, 2021

/retest

@sadasu sadasu force-pushed the fix-bmh-annotation branch 3 times, most recently from a73e2a4 to 1e52b8d Compare May 11, 2021 16:04
@sadasu sadasu changed the title Bug 1956607: Add annotations to all resources added to capm3.yaml Bug 1956607: Fix resources added to 0000_30_baremetal-operator_01_baremetalhost.crd.yaml May 11, 2021
@sadasu
Copy link
Author

sadasu commented May 11, 2021

/test e2e-metal-ipi-ovn-ipv6

@sadasu
Copy link
Author

sadasu commented May 11, 2021

/retest
Failures don't seem related to this PR.

@sadasu
Copy link
Author

sadasu commented May 12, 2021

/retest

1 similar comment
@sadasu
Copy link
Author

sadasu commented May 12, 2021

/retest

Makefile Outdated Show resolved Hide resolved
Dockerfile.ocp Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@zaneb
Copy link
Member

zaneb commented May 13, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu, zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented May 13, 2021

@sadasu: This pull request references Bugzilla bug 1956607, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (augol@redhat.com), skipping review request.

In response to this:

Bug 1956607: Fix resources added to 0000_30_baremetal-operator_01_baremetalhost.crd.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sadasu
Copy link
Author

sadasu commented May 13, 2021

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 175fa59 into openshift:master May 14, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 14, 2021

@sadasu: All pull requests linked via external trackers have merged:

Bugzilla bug 1956607 has been moved to the MODIFIED state.

In response to this:

Bug 1956607: Fix resources added to 0000_30_baremetal-operator_01_baremetalhost.crd.yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants