Vendor the apis submodule #162
Conversation
Downstream builds are failing because without the vendor directory, `go build` will try to download the modules from the internet.
openshift-ci
bot
added
the
approved
|
Hmmmm, maybe this isn't it. The images job previously passed without the vendor subdirectory. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest |
|
Builds succeeding in CI is not a perfect indicator of whether a component can build downstream in Red Hat's build infrastructure. The latter is restricted from accessing the Internet. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
I was finally able to reproduce the issue from brew in my local environment, and I'm pretty confident that this PR is the correct fix. |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asalkeld, honza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Downstream builds are failing because without the vendor directory,
go buildwill try to download the modules from the internet.