Bug 1986656: Fix missing case of BuildRAIDCleanSteps

[Hellcatlk]

I will pick up the upstream PRs after that has been merged, and will add that commits into this one.
URL of upstream PRs are as follows.

• Fix missing case of BuildRAIDCleanSteps metal3-io/baremetal-operator#942

Therefore, please pend the review of this PR.

[openshift-ci]

Hi @Hellcatlk. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hardys]

@Hellcatlk thanks for the PR - typically we do periodic rebases to pick up merged PRs from the upstream BMO repo (see recent merged PRs from @honza) so it may be best to follow that process again here I think?

[Hellcatlk]

/hold

[Hellcatlk]

@Hellcatlk thanks for the PR - typically we do periodic rebases to pick up merged PRs from the upstream BMO repo (see recent merged PRs from @honza) so it may be best to follow that process again here I think?

Understood, thanks for reminding, I will hold this PR

[openshift-ci]

@Hellcatlk: This pull request references Bugzilla bug 1986656, which is invalid:

• expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1986656: Ironic node enters the clean failed state when the target node doesn't have a RAID controller.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hase1128]

/bugzilla refresh

[openshift-ci]

@hase1128: This pull request references Bugzilla bug 1986656, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (augol@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hase1128]

@hardys

This PR's target is 4.9.0. Now there is the related BZ.
In this case, this PR is required to merge, right?

[rhjanders]

/bugzilla refresh

[openshift-ci]

@rhjanders: This pull request references Bugzilla bug 1986656, which is invalid:

• expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rhjanders]

/bugzilla refresh

[openshift-ci]

@rhjanders: This pull request references Bugzilla bug 1986656, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (augol@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Hellcatlk]

/hold cancel

[Hellcatlk]

/retest

[hase1128]

/retest

[honza]

/hold

All but the last commit are already present on the master branch so we don't need to include them. The only commit that we might want to bring in is the one introduced by the PR mentioned in the description.

metal3-io#942

Also, may I suggest using the -x flag of git cherry-pick when backporting code? It aids in any future git archeology endeavours.

[Hellcatlk]

/hold

All but the last commit are already present on the master branch so we don't need to include them. The only commit that we might want to bring in is the one introduced by the PR mentioned in the description.

metal3-io#942

Also, may I suggest using the -x flag of git cherry-pick when backporting code? It aids in any future git archeology endeavours.

@honza Thanks, done.

[rhjanders]

/test e2e-metal-ipi-ovn-ipv6

[rhjanders]

/retest

[hardys]

/retitle Bug 1986656: Fix missing case of BuildRAIDCleanSteps

(This makes it clearer this PR is now just a backport of metal3-io#942)

[hardys]

/approve

This looks like a valid backport of metal3-io#942 to me, thanks!

/cc @andfasano @dtantsur

[hardys]

/hold cancel

This is now just a backport of as requested by @honza

[sadasu]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hardys, Hellcatlk, sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hardys,sadasu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@Hellcatlk: All pull requests linked via external trackers have merged:

• openshift/baremetal-operator#170

Bugzilla bug 1986656 has been moved to the MODIFIED state.

In response to this:

Bug 1986656: Fix missing case of BuildRAIDCleanSteps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.