Bug 2000442: Add LIVE_ISO_FORCE_PERSISTENT_BOOT_DEVICE variable #174
Conversation
When using format: live-iso, two distinct use-cases exist: - Boot an installer ISO (non-persistent one-time boot desired) - Boot an ISO appliance (persistent live-iso boot desired). The original plan was to solve the installer-iso boot order via uefibootmgr (running from the live-iso), but this doesn't work reliably on all hardware. So expose a variable to control this behavior - in future we may want to consider a per-BMH variable, but for now expose a per-BMO variable. (cherry picked from commit 40fffc5) Conflicts: pkg/provisioner/ironic/ironic.go pkg/provisioner/ironic/update_opts.go
openshift-ci
bot
added
the
bugzilla/severity-urgent
|
@derekhiggins: This pull request references Bugzilla bug 2000442, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (augol@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/valid-bug
|
/approve |
openshift-ci
bot
added
the
approved
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekhiggins, dtantsur, hardys The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[patch-manager] 🚀 Approved for z-stream by score: 1.00 adding cherry-pick approved |
mfojtik
added
the
cherry-pick-approved
|
@derekhiggins: All pull requests linked via external trackers have merged: Bugzilla bug 2000442 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When using format: live-iso, two distinct use-cases exist:
The original plan was to solve the installer-iso boot order via
uefibootmgr (running from the live-iso), but this doesn't work
reliably on all hardware.
So expose a variable to control this behavior - in future we may
want to consider a per-BMH variable, but for now expose a
per-BMO variable.
(cherry picked from commit 40fffc5)
Conflicts:
pkg/provisioner/ironic/ironic.go
pkg/provisioner/ironic/update_opts.go