Commits on Oct 1, 2021

1. Avoid logging BMC password when creds change …

   Since b8dba2c we use the nodeUpdater
   with its built-in logging to update the ironic node when the credentials
   change. This inadvertantly meant the BMC credentials will be logged in
   this case (which is very rare; credentials don't often change).
   
   To prevent this, sanitise new values as they are being logged. Ironic
   does not return existing values for passwords, so there is no danger of
   them being logged through that route. Currently password fields are only
   redacted if they are set as part of a map; in practice this will be safe
   for the foreseeable future as the bmc credentials are always set through
   a map returned from the driver and not individually.
   
   (cherry picked from commit a08d0b6)

   

   zaneb committed Oct 1, 2021
   Copy the full SHA

   5071707 View commit details

   Browse the repository at this point in the history