Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2036006: Use integer value in clean steps for HostFirmwareSettings Integer type #199

Merged
merged 1 commit into from Jan 19, 2022

Conversation

bfournie
Copy link

For these types the value in clean steps should be stored as an integer,
otherwise vendors reject the Redfish request.

(cherry picked from commit b00f767)

For these types the value in clean steps should be stored as an integer,
otherwise vendors reject the Redfish request.

(cherry picked from commit b00f767)
@bfournie bfournie changed the title Use integer value in clean steps for HostFirmwareSettings Integer type Bug 2036006: Use integer value in clean steps for HostFirmwareSettings Integer type Jan 17, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 17, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jan 17, 2022

@bfournie: This pull request references Bugzilla bug 2036006, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (augol@redhat.com), skipping review request.

In response to this:

Bug 2036006: Use integer value in clean steps for HostFirmwareSettings Integer type

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bfournie
Copy link
Author

/test e2e-metal-ipi-serial-ipv4

@openshift-ci
Copy link

openshift-ci bot commented Jan 17, 2022

@bfournie: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ardaguclu
Copy link
Member

This cherry-pick looks good to me but I think @honza might want to look at due to impact on rebases.

/assign @honza

@honza
Copy link
Member

honza commented Jan 19, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jan 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie, honza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2022
@ardaguclu
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2022
@openshift-merge-robot openshift-merge-robot merged commit ef5de14 into openshift:master Jan 19, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jan 19, 2022

@bfournie: All pull requests linked via external trackers have merged:

Bugzilla bug 2036006 has been moved to the MODIFIED state.

In response to this:

Bug 2036006: Use integer value in clean steps for HostFirmwareSettings Integer type

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bfournie bfournie deleted the bug2036006 branch January 19, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants