Bug 2087213: Don't require pre-provisioning image for live ISO provisioning #231
Conversation
The live-iso provisioning method does not require IPA to be booted on the server, so don't fail if there is no PreprovisioningImage available. (cherry picked from commit 8577aac)
openshift-ci
bot
added
bugzilla/severity-urgent
|
@zaneb: This pull request references Bugzilla bug 2087213, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
If we are not cleaning the node then there is no need to have a preprovisioning image available for deprovisioning. (cherry picked from commit 78c95f8)
| return | ||
| } | ||
| } else { | ||
| if data.AutomatedCleaningMode == metal3v1alpha1.CleaningModeDisabled { |
There was a problem hiding this comment.
Why do we need this?
The cleaning mode is disabled in the converged flow as well.
There was a problem hiding this comment.
TBH I'm still not clear on what we're expecting to happen if we deprovision a host with cleaning disabled. If it doesn't involve trying to boot the image then this is OK, but if it does then there is no way for us to really fix this bug without re-enabling reconciliation of PreprovisioningImages with the InfraEnv label.
I could change this so it only applies when cleaning is disabled and the image is a live ISO, but it's not clear to me that that makes any difference. Perhaps @dtantsur can provide more info.
There was a problem hiding this comment.
When cleaning is disabled, deprovisioning only involves bookkeeping like detaching ISOs and clearing caches, so it's fine.
This logic is correct since we need to support the case of cleaning enabled.
|
@zaneb: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm Works in my testing. |
|
@zaneb: All pull requests linked via external trackers have merged: Bugzilla bug 2087213 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The live-iso provisioning method does not require IPA to be booted on
the server, so don't fail if there is no PreprovisioningImage available.
(cherry picked from commit 8577aac)