Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.13] OCPBUGS-17229: Set minimum TLS version for webhook to 1.2 #294

Conversation

zaneb
Copy link
Member

@zaneb zaneb commented Aug 2, 2023

No description provided.

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 2, 2023
@openshift-ci-robot
Copy link

@zaneb: This pull request references Jira Issue OCPBUGS-17229, which is invalid:

  • expected dependent Jira Issue OCPBUGS-17038 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Aug 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2023
@zaneb zaneb force-pushed the openshift-4.13/tls-min-version branch from 146066e to ccbbaad Compare August 2, 2023 22:15
@zaneb
Copy link
Member Author

zaneb commented Aug 2, 2023

/cherry-pick release-4.12

@openshift-cherrypick-robot

@zaneb: once the present PR merges, I will cherry-pick it on top of release-4.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zaneb zaneb force-pushed the openshift-4.13/tls-min-version branch 2 times, most recently from f26347d to 16b1f4c Compare August 4, 2023 06:41
@honza
Copy link
Member

honza commented Aug 4, 2023

The commit doesn't match the PR description.

@zaneb zaneb force-pushed the openshift-4.13/tls-min-version branch from 16b1f4c to f26347d Compare August 4, 2023 11:23
@zaneb
Copy link
Member Author

zaneb commented Aug 4, 2023

The commit doesn't match the PR description.

Thanks, I definitely forced-pushed something intended for another PR to the wrong branch 🤦
I was wondering where that change had gone! Fixed now.

@zaneb
Copy link
Member Author

zaneb commented Aug 6, 2023

/jira refresh
/retest-required

@openshift-ci-robot
Copy link

@zaneb: This pull request references Jira Issue OCPBUGS-17229, which is invalid:

  • expected dependent Jira Issue OCPBUGS-17038 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh
/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Aug 7, 2023

@zaneb: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zaneb zaneb changed the title OCPBUGS-17229: Set minimum TLS version for webhook to 1.2 [release-4.13] OCPBUGS-17229: Set minimum TLS version for webhook to 1.2 Aug 7, 2023
@zaneb
Copy link
Member Author

zaneb commented Aug 7, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 7, 2023
@zaneb
Copy link
Member Author

zaneb commented Aug 8, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 8, 2023
@openshift-ci-robot
Copy link

@zaneb: This pull request references Jira Issue OCPBUGS-17229, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-17038 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-17038 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @pamoedom

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from pamoedom August 8, 2023 09:53
@zaneb
Copy link
Member Author

zaneb commented Aug 8, 2023

/assign @dtantsur
@pamoedom need cherry-pick-approved on this PR please

@jadhaj
Copy link

jadhaj commented Aug 8, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 8, 2023
@honza
Copy link
Member

honza commented Aug 8, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2023
@openshift-merge-robot openshift-merge-robot merged commit 96e931b into openshift:release-4.13 Aug 8, 2023
7 checks passed
@openshift-ci-robot
Copy link

@zaneb: Jira Issue OCPBUGS-17229: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17229 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@zaneb: new pull request created: #297

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link

Fix included in accepted release 4.13.0-0.nightly-2023-08-08-191218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants