New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-23324: Backport node poweroff fixes #318
OCPBUGS-23324: Backport node poweroff fixes #318
Conversation
The host needs to be registered if we are going to power it off.
Namely registering, unmanaged, and none. This is to prevent a stuck case where incorrect credentials have been provided.
@honza: This pull request references Jira Issue OCPBUGS-23324, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: honza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/label acknowledge-critical-fixes-only This is blocking testing |
/retest |
/label backport-risk-assessed |
@elfosardo: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@elfosardo: This pull request references Jira Issue OCPBUGS-23324, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
/label backport-risk-assessed |
@iurygregory: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/remove-lifecycle stale |
/jira refresh |
@iurygregory: This pull request references Jira Issue OCPBUGS-23324, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label backport-risk-assessed |
@jadhaj when you have a chance can you add the cherry-pick-approved? Thanks! |
/label cherry-pick-approved |
@honza: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
937b5fd
into
openshift:release-4.14
@honza: Jira Issue OCPBUGS-23324: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-23324 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-baremetal-operator-container-v4.14.0-202403212313.p0.g937b5fd.assembly.stream.el8 for distgit ose-baremetal-operator. |
Fix included in accepted release 4.14.0-0.nightly-2024-03-23-013136 |
From 4.15 to 4.14.