Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

METAL-376: Re-enable RAID interfaces #319

Merged

Conversation

MahnoorAsghar
Copy link

@MahnoorAsghar MahnoorAsghar commented Nov 20, 2023

Re-enable RAID interfaces which were previously disabled only in OpenShift BMO (downstream), to be able to support RAID configuration using OpenShift BMO.
This change reverts:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 20, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 20, 2023

@MahnoorAsghar: This pull request references METAL-376 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Re-enable RAID interfaces to configure RAID

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MahnoorAsghar
Copy link
Author

/retest-required

@MahnoorAsghar MahnoorAsghar force-pushed the redfish-raid-ocp branch 2 times, most recently from 0184ba5 to 1322d3a Compare November 21, 2023 11:58
@honza
Copy link
Member

honza commented Nov 21, 2023

Since this is a downstream-only change, I'd like to see the reason for the change in the commit message.

Re-enable RAID interfaces which were previously disabled only in
OpenShift BMO (downstream), to be able to support RAID configuration
using OpenShift BMO
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 21, 2023

@MahnoorAsghar: This pull request references METAL-376 which is a valid jira issue.

In response to this:

Re-enable RAID interfaces which were previously disabled only in OpenShift BMO (downstream), to be able to support RAID configuration using OpenShift BMO.
This change reverts:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dtantsur
Copy link
Member

/approve

Note that we're asked to hold on any changes until next week.

Copy link

openshift-ci bot commented Nov 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, MahnoorAsghar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2023
Copy link

openshift-ci bot commented Nov 21, 2023

@MahnoorAsghar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elfosardo
Copy link

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 27, 2023
@elfosardo
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023
@elfosardo
Copy link

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 27, 2023
@dtantsur
Copy link
Member

/label acknowledge-critical-fixes-only

This does not qualify as a critical fix, but the label requirement is supposed to expire this week, and I haven't seen any information about it being prolonged.

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Nov 27, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 99b535c into openshift:master Nov 27, 2023
8 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-baremetal-operator-container-v4.15.0-202311271250.p0.g99b535c.assembly.stream for distgit ose-baremetal-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants