New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-ISSUE: Merge upstream #347
NO-ISSUE: Merge upstream #347
Conversation
When bumping gophercloud/v2 to v2.0.0-beta.2, it brought along a patch version to go directive in root go.mod. This set up a very strict golang requirement on BMO, which was made worse by the golang bump to v1.21.9. My PR in gophercloud fixed this issue, and we need to take in this v2.0.0-beta.3 + some commtis to include the fix, in order to not release BMO 0.6.0 with this requirement. In main, we should aim to bump to beta.4 as soon as it is released and preferably cherry-pick that to release-0.6 branch too. Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
🌱 bump gophercloud/v2 to beta.3 + some commits to fix go.mod
Signed-off-by: adil ghaffar <muhammad.adil.ghaffar@est.tech>
🌱 Fixing go mod mismatches and uplifting go mods.
Signed-off-by: adil ghaffar <muhammad.adil.ghaffar@est.tech>
🌱 Bump controller-runtime to v0.16.3 and CAPI to v1.6.4
Signed-off-by: Huy Mai <huy.mai@est.tech>
Signed-off-by: Huy Mai <huy.mai@est.tech>
…-dependence 🌱 Remove capm3_e2e dependency from bmo E2E
We already have a test provisioner, one more is unnecessary. Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
…on-mismatch 🌱 Fix mismatched versions between imported and cli ginkgo
🌱 Remove redundant Provisioner from HostFirmwareSettings tests
Signed-off-by: Mohammed Boukhalfa <mohammed.boukhalfa@est.tech>
Few improvements from previous minor release cycle: - add missing k8s.io/apiserver to module sync - change artefact to artifact for more common spelling - match container image detection from release notes to match the earlier change in the release tooling - rename some of the titles to be more descriptive - mutate go.mod files for osv-scanner so it can accurately report vulnerablities in golang stdlib (ie. mutate "go 1.21" directive to "go 1.21.9" with patch version read off from main Dockerfile - check version of osv-scanner, <1.5.0 give weird warnings now - make docker pull gcrane and osv-scanner images always, so it uses the newest versions Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
…-migrating-to-prow-/mohammed 🌱 Update CI triggers after migrating to prow jenkins operator
provisioner Signed-off-by: Himanshu Roy <hroy@redhat.com>
api definition Signed-off-by: Himanshu Roy <hroy@redhat.com>
Signed-off-by: Himanshu Roy <hroy@redhat.com>
… for BMH and DataImage controllers Signed-off-by: Himanshu Roy <hroy@redhat.com>
Signed-off-by: Himanshu Roy <hroy@redhat.com>
Signed-off-by: Himanshu Roy <hroy@redhat.com>
…, minor fixes Signed-off-by: Himanshu Roy <hroy@redhat.com>
…ling Signed-off-by: Himanshu Roy <hroy@redhat.com>
lastReconciled status field Signed-off-by: Himanshu Roy <hroy@redhat.com>
Signed-off-by: Himanshu Roy <hroy@redhat.com>
…lease 🌱 improve hack/verify-release.sh script
✨ Attach non-bootable iso to BareMetalHost
Signed-off-by: Himanshu Roy <hroy@redhat.com>
@hroyrh: This pull request explicitly references no jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Signed-off-by: Himanshu Roy <hroy@redhat.com>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur, hroyrh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@hroyrh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-baremetal-operator-container-v4.16.0-202404250649.p0.gb5ade06.assembly.stream.el9 for distgit ose-baremetal-operator. |
No description provided.