Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1835419: Add a tool to convert introspection data to HardwareDetails #67

Merged
merged 3 commits into from May 13, 2020
Merged

Bug 1835419: Add a tool to convert introspection data to HardwareDetails #67

merged 3 commits into from May 13, 2020

Conversation

stbenjam
Copy link
Member

Bringing in metal3-io#515 and metal3-io#520

@stbenjam
Add a tool to convert introspection data to HardwareDetails
9769130 
This adds a tool called "make-introspection" that takes 2 arguments,
the Ironic inspector URI and then node UUID. It queries inspector
for the data, and if found, converts it to the BareMetalHost
HardwareDetails format.
@stbenjam
Rename make-introspection to get-hardware-details
a794f47 
This name is more descriptive.
@stbenjam
Add get-hardware-details binary to baremetal-operator image
d31e0f9
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label May 13, 2020
@openshift-ci-robot
Copy link

@stbenjam: This pull request references Bugzilla bug 1835419, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1835419: Ad a tool to convert introspection data to HardwareDetails

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 13, 2020
@stbenjam stbenjam changed the title Bug 1835419: Ad a tool to convert introspection data to HardwareDetails Bug 1835419: Add a tool to convert introspection data to HardwareDetails May 13, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2020
@stbenjam
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels May 13, 2020
@openshift-ci-robot
Copy link

@stbenjam: This pull request references Bugzilla bug 1835419, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 13, 2020
@stbenjam
Copy link
Member Author

/test images

@dhellmann
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9cbe3b6 into openshift:master May 13, 2020
@openshift-ci-robot
Copy link

@stbenjam: All pull requests linked via external trackers have merged: openshift/baremetal-operator#67. Bugzilla bug 1835419 has been moved to the MODIFIED state.

In response to this:

Bug 1835419: Add a tool to convert introspection data to HardwareDetails

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam stbenjam deleted the make-introspection branch May 13, 2020 19:54
@hardys
Copy link

hardys commented Jul 28, 2020

/cherry-pick release-4.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhellmann dhellmann Awaiting requested review from dhellmann

@honza honza Awaiting requested review from honza

Assignees

@dhellmann dhellmann

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stbenjam @openshift-ci-robot @dhellmann @hardys @openshift-merge-robot