Bug 1835457: Put BMH status in annotation while reconciliation #68
Conversation
openshift-ci-robot
added
the
bugzilla/severity-unspecified
|
@stbenjam: This pull request references Bugzilla bug 1835457, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
openshift-ci-robot
added
the
approved
|
Per @dhellmann I'll need to yoink metal3-io#516 when it merges |
If we are copying the Status in from a baremetalhost.metal3.io/status annotation, return and requeue immediately after writing it rather than try to continue to do other things, which may result in a write conflict. Also, invert the output of the hostHasStatus() method, so that it no longer returns the exact opposite of what it says on the tin.
|
@stbenjam: This pull request references Bugzilla bug 1835457, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This cherry-pick looks good to me. I'll wait for @mhrivnak's question to be resolved before approving formally. |
|
Linting fix: metal3-io#521 |
|
Looks good to me. |
The lint target does not work, yet, because generate-sdk fails. Add a separate target for golint and then have travis use that as a quick way to enforce it until we can set up a prow job. Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
The upstream lint target in make is overloaded and is trying to do too much.
|
/test images |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@stbenjam: All pull requests linked via external trackers have merged: openshift/baremetal-operator#68. Bugzilla bug 1835457 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Upstream added support to populate introspection via annotation, we need to backport this into baremetal-operator so we can populate masters IP information to make the node/machine link.