Sync downstream 20200716 #86
Conversation
If the power state is correct then we don't need to save host status.
The extra requeues added in 871926d to ensure that the Status got written immediately after updating the status annotation were incompletely reverted by f1b81a0, after which they are no longer required as we no longer write a status annotation and just write the Status immediately. This reverts the remaining changes to prevent unnecessary requeueing.
If a host is paused, there is no need to reconcile it periodically. Any change that removes the pause annotation will trigger normal reconciliation. See comments on metal3-io#589 for more context Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
Use actionContinueNoWrite when power State == desired
…requeues Avoid extra requeues when credentials missing
…ed-hosts stop reconciling paused hosts
openshift-ci-robot
added
the
approved
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, honza, zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This PR includes a few changes to behavior for syncing hosts that are paused or that have errors. It also includes a change to not update a host when the power state matches the desired state, so that the host is not constantly being reconciled twice per minute.