Bug 1875558: Always delete found host from Ironic on deletion #96
Conversation
When we go to delete a node we look it up by either the UUID stored in the Host or by name, but previously when we deleted it from Ironic we only used the UUID from the Host. This meant if the Host UUID was empty or didn't match, we would be stuck in a loop from which we could never recover. We can't have it both ways; either a node found by name is the one that matches and we should delete it, or it isn't and we should report that the node cannot be found and thus the delete is complete. It is not clear under what circumstances we end up in this state. It is possible that it involves the node being discovered by Ironic before the Host is created and then immediately deleted. Treat a host matching by name as the one we are looking for, and delete it regardless of whether we had already stored the node ID. Fixes metal3-io#482 (cherry picked from commit ad79872)
openshift-ci-robot
added
the
approved
dhellmann
changed the title
openshift-ci-robot
added
the
bugzilla/severity-medium
|
@dhellmann: This pull request references Bugzilla bug 1875558, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@dhellmann: All pull requests linked via external trackers have merged: Bugzilla bug 1875558 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When we go to delete a node we look it up by either the UUID stored in
the Host or by name, but previously when we deleted it from Ironic we
only used the UUID from the Host. This meant if the Host UUID was empty
or didn't match, we would be stuck in a loop from which we could never
recover. We can't have it both ways; either a node found by name is the
one that matches and we should delete it, or it isn't and we should
report that the node cannot be found and thus the delete is complete.
It is not clear under what circumstances we end up in this state. It is
possible that it involves the node being discovered by Ironic before the
Host is created and then immediately deleted.
Treat a host matching by name as the one we are looking for, and delete
it regardless of whether we had already stored the node ID.
Fixes metal3-io#482
(cherry picked from commit ad79872)