Bug 1872632: runtimecfg node-ip: allow running without VIPs #101
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
|
@danwinship: This pull request references Bugzilla bug 1872632, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The code would crash with a nil dereference if you didn't pass utils.NonDefaultRoute as the RouteFilter, so don't make that optional; the function documentation already implies that it ignores non-default routes anyway. Also, move the filtering into getAddressMap() and getRouteMap(). In particular, this makes it so that the passed-in AddressFilter also gets applied in the IPv4 / non-/128-IPv6 case.
danwinship
force-pushed
the
upi-nodeip
branch
from
b9721e6
to
859ccd4
Compare
danwinship
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
@danwinship: This pull request references Bugzilla bug 1872632, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Allow running "runtimecfg node-ip" with no Virtual IP arguments, to select an IP based on the default route. This will be used for bare metal UPI environments, where kubelet may not pick the default node IP correctly, but there is no apiserver VIP to use as a hint.
danwinship
force-pushed
the
upi-nodeip
branch
from
859ccd4
to
1cd2a95
Compare
|
/approve |
openshift-ci-robot
added
the
approved
|
/assign @cybertron @bcrochet |
|
/lgtm I played around with this locally and it handled all of the combinations of addresses that I tried. Should be good to go. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: celebdor, cybertron, danwinship The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@danwinship: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Bugzilla bug 1872632 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
"runtimecfg node-ip" is currently only used on bare metal IPI, and depends on being given an apiserver VIP to use as a hint to figure out the node IP to use. In some cases kubelet also needs help figuring out the default node IP on bare metal UPI, but we have no apiserver VIP to use there. This extends "runtimecfg node-ip" to allow running with no VIPs, in which case it just picks an IP based on the default route.
/cc @celebdor