Remove get boostrap IP code #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
yboaron
force-pushed
the
delete_get_bootstrap
branch
from
52dac05
to
c5a202a
Compare
Since we eliminate the need for the master nodes to know the bootstrap IP address for unicast Keepalived, we can delete the code that implements this functionality.
yboaron
force-pushed
the
delete_get_bootstrap
branch
from
c5a202a
to
1b07154
Compare
|
e2e-metal-ipi gate is red because openshift/machine-config-operator#2185 wasn't merged yet. |
cybertron
approved these changes
Oct 28, 2020
|
/test e2e-metal-ipi |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cybertron, yboaron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we eliminate the need for the master nodes to know the bootstrap IP address
for unicast Keepalived, we can delete the code that implements this functionality.
Depends on : MCO PR