Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merge pull request #141 from yboaron/get_endpoints" #146

Merged
merged 1 commit into from Jul 18, 2021
Merged

Revert "Merge pull request #141 from yboaron/get_endpoints" #146

merged 1 commit into from Jul 18, 2021

Conversation

yboaron
Copy link
Contributor

@yboaron yboaron commented Jun 24, 2021

This reverts commit c8b1456, reversing
changes made to e6b36b2.

We can merge this PR after openshift/machine-config-operator#2637 will be merged

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2021
@yboaron
Copy link
Contributor Author

yboaron commented Jun 24, 2021

/hold

Until openshift/machine-config-operator#2637 will be merged

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2021
@yboaron yboaron mentioned this pull request Jun 24, 2021
Merged
mandre
mandre reviewed Jun 24, 2021
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, yboaron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yboaron
Copy link
Contributor Author

yboaron commented Jul 18, 2021

openshift/machine-config-operator#2637 was merged, we should be good to go

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2021
@yboaron
Copy link
Contributor Author

yboaron commented Jul 18, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6bd3398 into openshift:master Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre left review comments

@celebdor celebdor Awaiting requested review from celebdor

@cybertron cybertron Awaiting requested review from cybertron

Assignees

@mandre mandre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yboaron @openshift-bot @mandre @openshift-merge-robot