RFE-2962: Set interface name from node-ip-configuration to configure-ovs #186
Conversation
node-ip-configuration will set env file for configure-ovs when it will set kubelet ip, this will allow to configure ovs with the bridge on the same interface that kubelet will use
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tsorya The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| // in that case don't change the previous written interface | ||
| if chosenAddresses[0].LinkName != "br-ex" { | ||
| interfaceDir := filepath.Dir(interfaceFile) | ||
| err = os.MkdirAll(interfaceDir, 0755) |
There was a problem hiding this comment.
should we check if the interfaceDir exists before trying to create?
|
|
||
| // Set interface in case it is not br-ex that means that it was already configured and node is rebooting | ||
| // in that case don't change the previous written interface | ||
| if chosenAddresses[0].LinkName != "br-ex" { |
There was a problem hiding this comment.
br-ex seems a good candidate for const ?
| err = os.MkdirAll(interfaceDir, 0755) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
From line 144 to 160 can be a helper function IMHO
|
Similar to #183 ? |
|
it was decided to go with ip address and not setting interface |
node-ip-configuration will set env file for configure-ovs when it will
set kubelet ip, this will allow to configure ovs with the bridge on the
same interface that kubelet will use