New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPNET-192: update centos version #212
Conversation
Update Dockerfile for most recent CentOS Stream (9). Signed-off-by: Douglas Schilling Landgraf <dlandgra@redhat.com>
@dougsland: This pull request references Jira Issue OCPBUGS-3988, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dougsland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh |
@dougsland: This pull request references Jira Issue OCPBUGS-3988, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@dougsland: This pull request references Jira Issue OCPBUGS-3988, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dougsland: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Also tested against OCP 4.11 and 4.12 everything worked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The verify-api-int-resolvable
is effectively running from the baremetal-runtimecfg image and the container seems to be working fine with this change.
However, while useful to bump dependencies, this just shows that the centos-9 based baremetal-runtimecfg image can execute oc
from a RHEL8-based RHCOS.
Is this Dockerfile the source for baremetal-runtimecfg image that will be in the OCP payload, or is it only used in CI?
I'd like to understand if it's correct to reference OCPBUGS-3988 here.
My understanding is that CI uses Dockerfile.openshift. I was expecting that |
Adding @dollierp in the loop. |
It seems like CI is using Dockerfile.openshift, so the change was apparently not tested in CI. Not sure where Dockerfile is used. |
This is only used for local builds (like in dev-scripts). This is probably fine since 4.13 will be based on 9, but it doesn't fix the problem in actual release builds. I'm actually wondering if we should just change how we check for api-int. There's no particular reason we need to call oc, we could just curl api-int.cluster-domain/readyz which would be a lot lighter and wouldn't have this problem. |
@dougsland: This pull request references OPNET-192 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I changed the reference on this to point at the RHCOS 9 epic instead of the bug. We should probably wait to merge it until the regular OpenShift base images are 9-based too. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Update Dockerfile for most recent CentOS Stream (9).
Signed-off-by: Douglas Schilling Landgraf dlandgra@redhat.com