Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPNET-192: update centos version #212

Closed
wants to merge 1 commit into from

Conversation

dougsland
Copy link
Contributor

Update Dockerfile for most recent CentOS Stream (9).

Signed-off-by: Douglas Schilling Landgraf dlandgra@redhat.com

Update Dockerfile for most recent CentOS Stream (9).

Signed-off-by: Douglas Schilling Landgraf <dlandgra@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. label Dec 7, 2022
@openshift-ci-robot
Copy link
Contributor

@dougsland: This pull request references Jira Issue OCPBUGS-3988, which is invalid:

  • expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Update Dockerfile for most recent CentOS Stream (9).

Signed-off-by: Douglas Schilling Landgraf dlandgra@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougsland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2022
@dougsland
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@dougsland: This pull request references Jira Issue OCPBUGS-3988, which is invalid:

  • expected the bug to target the "4.13.0" version, but it targets "4.13" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dougsland
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 7, 2022
@openshift-ci-robot
Copy link
Contributor

@dougsland: This pull request references Jira Issue OCPBUGS-3988, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @pamoedom

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from pamoedom December 7, 2022 18:50
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 7, 2022

@dougsland: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dougsland
Copy link
Contributor Author

Also tested against OCP 4.11 and 4.12 everything worked.

Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The verify-api-int-resolvable is effectively running from the baremetal-runtimecfg image and the container seems to be working fine with this change.

However, while useful to bump dependencies, this just shows that the centos-9 based baremetal-runtimecfg image can execute oc from a RHEL8-based RHCOS.

Is this Dockerfile the source for baremetal-runtimecfg image that will be in the OCP payload, or is it only used in CI?
I'd like to understand if it's correct to reference OCPBUGS-3988 here.

@dougsland
Copy link
Contributor Author

The verify-api-int-resolvable is effectively running from the baremetal-runtimecfg image and the container seems to be working fine with this change.

However, while useful to bump dependencies, this just shows that the centos-9 based baremetal-runtimecfg image can execute oc from a RHEL8-based RHCOS.

Is this Dockerfile the source for baremetal-runtimecfg image that will be in the OCP payload, or is it only used in CI? I'd like to understand if it's correct to reference OCPBUGS-3988 here.

My understanding is that CI uses Dockerfile.openshift. I was expecting that master branch shouldn't be a problem replacing the stream from 8 to 9.

@dougsland
Copy link
Contributor Author

Adding @dollierp in the loop.

@mandre
Copy link
Member

mandre commented Dec 9, 2022

It seems like CI is using Dockerfile.openshift, so the change was apparently not tested in CI. Not sure where Dockerfile is used.

@cybertron
Copy link
Member

This is only used for local builds (like in dev-scripts). This is probably fine since 4.13 will be based on 9, but it doesn't fix the problem in actual release builds.

I'm actually wondering if we should just change how we check for api-int. There's no particular reason we need to call oc, we could just curl api-int.cluster-domain/readyz which would be a lot lighter and wouldn't have this problem.

@cybertron cybertron changed the title OCPBUGS-3988: update centos version OPNET-192: update centos version Feb 6, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. and removed jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Feb 6, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 6, 2023

@dougsland: This pull request references OPNET-192 which is a valid jira issue.

In response to this:

Update Dockerfile for most recent CentOS Stream (9).

Signed-off-by: Douglas Schilling Landgraf dlandgra@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cybertron
Copy link
Member

I changed the reference on this to point at the RHCOS 9 epic instead of the bug. We should probably wait to merge it until the regular OpenShift base images are 9-based too.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 8, 2023
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 7, 2023
@dougsland dougsland closed this Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants