OCPBUGS-12739: Use NonVirtualIP as a hint for selecting Peers

[mkowalski]

This PR extends the logic of using OVN annotations for selecting keepalived peers. With this change we will at first try to use local Node IP if available and only afterwards run the full heuristic that uses OVN annotations.

By using GetVRRPConfig() for generating both NonVirtualIP and entry in IngressConfig.Peers list we should guarantee that participateInIngressVRPP evaluates correctly even if node has multiple IP addresses in the same subnet.

Contributes-to: OCPBUGS-12739

[openshift-ci-robot]

@mkowalski: This pull request references Jira Issue OCPBUGS-12739, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @rbbratta

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR extends the logic of using OVN annotations for selecting keepalived peers. With this change we will at first try to use local Node IP if available and only afterwards run the full heuristic that uses OVN annotations.

By using GetVRRPConfig() for generating both NonVirtualIP and entry in IngressConfig.Peers list we should guarantee that participateInIngressVRPP evaluates correctly even if node has multiple IP addresses in the same subnet.

Contributes-to: OCPBUGS-12739

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mkowalski]

/cc @cybertron
/test all

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

@mkowalski: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[cybertron]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, mkowalski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cybertron,mkowalski]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@mkowalski: Jira Issue OCPBUGS-12739: All pull requests linked via external trackers have merged:

• openshift/baremetal-runtimecfg#241
• openshift/baremetal-runtimecfg#252
• openshift/baremetal-runtimecfg#253
• openshift/baremetal-runtimecfg#254
• openshift/baremetal-runtimecfg#256

Jira Issue OCPBUGS-12739 has been moved to the MODIFIED state.

In response to this:

This PR extends the logic of using OVN annotations for selecting keepalived peers. With this change we will at first try to use local Node IP if available and only afterwards run the full heuristic that uses OVN annotations.

By using GetVRRPConfig() for generating both NonVirtualIP and entry in IngressConfig.Peers list we should guarantee that participateInIngressVRPP evaluates correctly even if node has multiple IP addresses in the same subnet.

Contributes-to: OCPBUGS-12739

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.