Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.14] OCPBUGS-23474: Use shorter IP label for keepalived VIP #288

Merged
merged 1 commit into from Nov 29, 2023
Merged

[release-4.14] OCPBUGS-23474: Use shorter IP label for keepalived VIP #288

merged 1 commit into from Nov 29, 2023
+2 −2

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #287

/assign mkowalski

@mkowalski
OCPBUGS-23432: Use shorter IP label for keepalived VIP
a32001e 
This PR modifies the label used for an IP address assigned by keepalived
to not include the name of the interface. This is because the maximum
allowed lenght of the label is 15 characters, causing stuff to fail when
interface itself has a name longer than 12 characters.

With this change the label will always be a simple string of length 3
and will not be susceptible to overflow for long NIC names.

Contributes-to: OCPBUGS-23432
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 21, 2023
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-23432 has been cloned as Jira Issue OCPBUGS-23474. Will retitle bug to link to clone.
/retitle [release-4.14] OCPBUGS-23474: Use shorter IP label for keepalived VIP

In response to this:

This is an automated cherry-pick of #287

/assign mkowalski

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.14] OCPBUGS-23432: Use shorter IP label for keepalived VIP [release-4.14] OCPBUGS-23474: Use shorter IP label for keepalived VIP Nov 21, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 21, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-23474, which is invalid:

  • expected dependent Jira Issue OCPBUGS-23432 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #287

/assign mkowalski

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mkowalski
Copy link
Contributor

/lgtm
/approve
/backport-risk-assessed

Clean backport

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkowalski, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2023
@mffiedler
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 21, 2023
@openshift-ci-robot openshift-ci-robot mentioned this pull request Nov 21, 2023
Merged
@mkowalski
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 21, 2023
@mkowalski
Copy link
Contributor

/test e2e-metal-ipi-ovn-ipv6

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 21, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cybertron
Copy link
Member

/jira refresh

Let's get this in so the bug status gets updated properly.

@openshift-ci-robot
Copy link
Contributor

@cybertron: This pull request references Jira Issue OCPBUGS-23474, which is invalid:

  • expected dependent Jira Issue OCPBUGS-23432 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Let's get this in so the bug status gets updated properly.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson sdodson added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 29, 2023
@sdodson
Copy link
Member

sdodson commented Nov 29, 2023

/jira refresh
Setting jira/valid-bug on this test code update so that if we decide that the test update is necessary for the bug to be attached to the errata it at least makes it in this week.

@openshift-ci-robot
Copy link
Contributor

@sdodson: This pull request references Jira Issue OCPBUGS-23474, which is invalid:

  • expected dependent Jira Issue OCPBUGS-23432 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Retaining the jira/valid-bug label as it was manually added.

In response to this:

/jira refresh
Setting jira/valid-bug on this test code update so that if we decide that the test update is necessary for the bug to be attached to the errata it at least makes it in this week.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Nov 29, 2023

/tide refresh

@openshift-merge-bot openshift-merge-bot bot merged commit 4b7c64b into openshift:release-4.14 Nov 29, 2023
7 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-23474: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-23474 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #287

/assign mkowalski

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-baremetal-runtimecfg-container-v4.14.0-202311291651.p0.g4b7c64b.assembly.stream for distgit baremetal-runtimecfg.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2023-11-29-234603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cybertron cybertron Awaiting requested review from cybertron

@mkowalski mkowalski Awaiting requested review from mkowalski

Assignees

@mkowalski mkowalski

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@openshift-cherrypick-robot @openshift-ci-robot @mkowalski @mffiedler @cybertron @sdodson @openshift-bot @openshift-merge-robot