Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-29919: Decrease log level when detecting node IP #301

Merged
merged 1 commit into from Apr 5, 2024
Merged

OCPBUGS-29919: Decrease log level when detecting node IP #301

merged 1 commit into from Apr 5, 2024
+10 −12

Conversation

mkowalski
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 6, 2024
@openshift-ci-robot
Copy link
Contributor

@mkowalski: This pull request references Jira Issue OCPBUGS-29919, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
@mkowalski
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 6, 2024
@openshift-ci-robot
Copy link
Contributor

@mkowalski: This pull request references Jira Issue OCPBUGS-29919, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from zhaozhanqi March 6, 2024 15:07
@mkowalski
Copy link
Contributor Author

/cc @cybertron

@mkowalski
Copy link
Contributor Author

/retest-required

@cybertron
Copy link
Member

/retest
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, mkowalski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cybertron,mkowalski]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 57d3465 and 2 for PR HEAD 055e706 in total

@mkowalski
Copy link
Contributor Author

/retest-required

 Errors during downloading metadata for repository 'rhel-9-nfv-ppc64le':
  - Status code: 404 for http://base-4-16-rhel9.ocp.svc/rhel-9-nfv-ppc64le/repodata/repomd.xml (IP: 172.30.215.194)
Error: Failed to download metadata for repo 'rhel-9-nfv-ppc64le': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried
error: build error: building at STEP "RUN yum install -y dhclient diffutils && yum clean all": while running runtime: exit status 1

@mkowalski mkowalski mentioned this pull request Mar 13, 2024
Closed
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 57d3465 and 2 for PR HEAD 055e706 in total

@mkowalski
Copy link
Contributor Author

/retest-required

 Errors during downloading metadata for repository 'rhel-9-nfv-ppc64le':
  - Status code: 404 for http://base-4-16-rhel9.ocp.svc/rhel-9-nfv-ppc64le/repodata/repomd.xml (IP: 172.30.202.53)
Error: Failed to download metadata for repo 'rhel-9-nfv-ppc64le': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried

@mkowalski
Copy link
Contributor Author

/test images

1 similar comment
@jupierce
Copy link
Contributor

jupierce commented Apr 3, 2024

/test images

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 3, 2024 •
edited

@mkowalski: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi 055e706 link false /test e2e-metal-ipi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jupierce
Copy link
Contributor

jupierce commented Apr 3, 2024

/test images

@mkowalski
Copy link
Contributor Author

/test e2e-metal-ipi-ovn-ipv6

@openshift-merge-bot openshift-merge-bot bot merged commit a77854c into openshift:master Apr 5, 2024
7 of 8 checks passed
@openshift-ci-robot
Copy link
Contributor

@mkowalski: Jira Issue OCPBUGS-29919: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-29919 has not been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mkowalski mkowalski deleted the OCPBUGS-29919 branch April 5, 2024 12:30
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-baremetal-runtimecfg-container-v4.16.0-202404050813.p0.ga77854c.assembly.stream.el9 for distgit baremetal-runtimecfg.
All builds following this will include this PR.

@mkowalski
Copy link
Contributor Author

/cherry-pick release-4.15

@openshift-cherrypick-robot
Copy link

@mkowalski: new pull request created: #304

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 10, 2024
Merged
@mkowalski
Copy link
Contributor Author

/jira-refresh

@mkowalski
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@mkowalski: Jira Issue OCPBUGS-29919 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@zhaozhanqi
Copy link

/jira-refresh

@zhaozhanqi
Copy link

/jira refresh

@openshift-bot
Copy link
Contributor

@zhaozhanqi: Jira Issue OCPBUGS-29919: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29919 has been moved to the MODIFIED state.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

mkowalski added a commit to mkowalski/baremetal-runtimecfg that referenced this pull request Apr 17, 2024
@mkowalski
OCPBUGS-32348: Make log level configurable
0561ac2 
In openshift#301 we have
decreased level from INFO to DEBUG for multiple messages around Node IP
detection logic. However, we never implemented ability to enable DEBUG
level so that those logs were effectively unreachable.

With this PR we will consume `ENABLE_NODEIP_DEBUG` env variable and if
configured, we will increase log level.

For OpenShift customers the variable will be consumed via ConfigMap as
defined in the respective Pod manifest in the MCO repository.

Fixes: OCPBUGS-32348
@mkowalski mkowalski mentioned this pull request Apr 17, 2024
Merged
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/baremetal-runtimecfg that referenced this pull request Apr 22, 2024
@mkowalski
OCPBUGS-32348: Make log level configurable
6e22e81 
In openshift#301 we have
decreased level from INFO to DEBUG for multiple messages around Node IP
detection logic. However, we never implemented ability to enable DEBUG
level so that those logs were effectively unreachable.

With this PR we will consume `ENABLE_NODEIP_DEBUG` env variable and if
configured, we will increase log level.

For OpenShift customers the variable will be consumed via ConfigMap as
defined in the respective Pod manifest in the MCO repository.

Fixes: OCPBUGS-32348
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cybertron cybertron Awaiting requested review from cybertron

@dougsland dougsland Awaiting requested review from dougsland

@zhaozhanqi zhaozhanqi Awaiting requested review from zhaozhanqi

Assignees

@cybertron cybertron

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mkowalski @openshift-ci-robot @cybertron @jupierce @openshift-bot @openshift-cherrypick-robot @zhaozhanqi