Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Fix wrong golang version, bump to 1.21 #311

Merged
merged 1 commit into from
May 8, 2024

Conversation

mkowalski
Copy link
Contributor

go.mod for quite some time defines golang version as 1.21, yet Dockerfile was never upgraded from 1.18

In order to make local builds possible again, we need to bump golang version in Dockerfile.

go.mod for quite some time defines golang version as 1.21, yet
Dockerfile was never upgraded from 1.18

In order to make local builds possible again, we need to bump golang
version in Dockerfile.
@openshift-ci openshift-ci bot requested review from cybertron and dougsland May 7, 2024 11:07
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2024
@mkowalski mkowalski changed the title Fix wrong golang version, bump to 1.21 NO-ISSUE: Fix wrong golang version, bump to 1.21 May 7, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 7, 2024
@openshift-ci-robot
Copy link
Contributor

@mkowalski: This pull request explicitly references no jira issue.

In response to this:

go.mod for quite some time defines golang version as 1.21, yet Dockerfile was never upgraded from 1.18

In order to make local builds possible again, we need to bump golang version in Dockerfile.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cybertron
Copy link
Member

/lgtm
/approve
/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2024
Copy link
Contributor

openshift-ci bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, mkowalski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cybertron,mkowalski]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented May 8, 2024

@mkowalski: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 38e8fed into openshift:master May 8, 2024
8 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-baremetal-runtimecfg-container-v4.16.0-202405100946.p0.g38e8fed.assembly.stream.el9 for distgit baremetal-runtimecfg.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants