OCPBUGS-32141: Handle scenario when VIP does not belong to L2

[mkowalski]

Lately we were made aware that the current logic of maching interfaces to VIPs is broken in vSphere IPI scenarios when VIP does not belong to Machine Network. Usually such a combination would be forbidden, but for vSphere it is allowed.

As a result, we may have e.g. an interface 10.8.38.29, machine network 10.8.42.0/23 and VIP 10.8.0.83. As counterintuitively it looks for baremetal, with vSphere it is allowed.

This PR fixes the logic we introduced in January 2023 where we added a hard-check to make sure VIP belongs to a subnet of the NIC. With this new logic, if the scenario described above happens, we will fallback to the logic from years ago when we were simply choosing a NodeInternalIP of the matching IP stack.

Closes: OCPBUGS-32141

[openshift-ci-robot]

@mkowalski: This pull request references Jira Issue OCPBUGS-32141, which is invalid:

• expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "4.14.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Lately we were made aware that the current logic of maching interfaces to VIPs is broken in vSphere IPI scenarios when VIP does not belong to Machine Network. Usually such a combination would be forbidden, but for vSphere it is allowed.

As a result, we may have e.g. an interface 10.8.38.29, machine network 10.8.42.0/23 and VIP 10.8.0.83. As counterintuitively it looks for baremetal, with vSphere it is allowed.

This PR fixes the logic we introduced in January 2023 where we added a hard-check to make sure VIP belongs to a subnet of the NIC. With this new logic, if the scenario described above happens, we will fallback to the logic from years ago when we were simply choosing a NodeInternalIP of the matching IP stack.

Closes: OCPBUGS-32141

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@mkowalski: once the present PR merges, I will cherry-pick it on top of release-4.15,release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.15,release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mkowalski]

/jira refresh

[openshift-ci-robot]

@mkowalski: This pull request references Jira Issue OCPBUGS-32141, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[cybertron]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, mkowalski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cybertron,mkowalski]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

[openshift-ci-robot]

@openshift-bot: This pull request references Jira Issue OCPBUGS-32141, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

[openshift-ci-robot]

@openshift-bot: This pull request references Jira Issue OCPBUGS-32141, which is invalid:

• expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "4.16.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[cybertron]

/jira refresh
/label acknowledge-critical-fixes-only

This is a fix for a common use case on vsphere that is now being found in the field. We can't wait for 4.16 to ship before we get it in.

[openshift-ci-robot]

@cybertron: This pull request references Jira Issue OCPBUGS-32141, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.0) matches configured target version for branch (4.17.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh
/label acknowledge-critical-fixes-only

This is a fix for a common use case on vsphere that is now being found in the field. We can't wait for 4.16 to ship before we get it in.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@mkowalski: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@mkowalski: Jira Issue OCPBUGS-32141: All pull requests linked via external trackers have merged:

• openshift/baremetal-runtimecfg#313

Jira Issue OCPBUGS-32141 has been moved to the MODIFIED state.

In response to this:

Lately we were made aware that the current logic of maching interfaces to VIPs is broken in vSphere IPI scenarios when VIP does not belong to Machine Network. Usually such a combination would be forbidden, but for vSphere it is allowed.

As a result, we may have e.g. an interface 10.8.38.29, machine network 10.8.42.0/23 and VIP 10.8.0.83. As counterintuitively it looks for baremetal, with vSphere it is allowed.

This PR fixes the logic we introduced in January 2023 where we added a hard-check to make sure VIP belongs to a subnet of the NIC. With this new logic, if the scenario described above happens, we will fallback to the logic from years ago when we were simply choosing a NodeInternalIP of the matching IP stack.

Closes: OCPBUGS-32141

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-baremetal-runtimecfg-container-v4.17.0-202405210211.p0.gbc72f01.assembly.stream.el9 for distgit baremetal-runtimecfg.
All builds following this will include this PR.