Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert /128 addresses to /64 again #42

Merged
merged 1 commit into from Jan 16, 2020

Conversation

derekhiggins
Copy link
Contributor

In order to select an interface for the VIPs we
are trying to find a interface with an IP in the
same subnet.

If using DHCPv6 then addresses have a /128 address,
assume in this case its enough to test if the VIP
is in the same /64.

Return the original IP address unchanged, the previous
version of this patch returned the network address in
error.

In order to select an interface for the VIPs we
are trying to find a interface with an IP in the
same subnet.

If using DHCPv6 then addresses have a /128 address,
assume in this case its enough to test if the VIP
is in the same /64.

Return the original IP address unchanged, the previous
version of this patch returned the network address in
error.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 16, 2020
Copy link
Member

@cybertron cybertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Tested this locally and it fixes the problem with the previous version.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, derekhiggins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2020
@openshift-merge-robot openshift-merge-robot merged commit 7951975 into openshift:master Jan 16, 2020
@russellb
Copy link
Member

/cherry-pick release-4.3

@openshift-cherrypick-robot

@russellb: new pull request created: #43

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants