runtimecfg: Add node-ip subcommand #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
|
Moved the implementation from openshift/machine-config-operator#1564 |
|
/hold Need to test a full deployment with the accompanying change in MCO that moves to use it. |
openshift-ci-robot
added
the
do-not-merge/hold
|
Need to add the retry on failure functionality from openshift/machine-config-operator#1601 to prevent a regression |
bcrochet
requested changes
Apr 16, 2020
bcrochet
approved these changes
Apr 16, 2020
|
/lgtm |
cybertron
requested changes
Apr 16, 2020
There was a problem hiding this comment.
This failed in my local testing:
Apr 16 18:23:31 master-0.ostest.test.metalkube.org podman[1899]: time="2020-04-16T18:23:31Z" level=info msg="Parsed Virtual IP fd2e:6f44:5dd8:c956::5"
Apr 16 18:23:31 master-0.ostest.test.metalkube.org podman[1899]: time="2020-04-16T18:23:31Z" level=fatal msg="error in node-ip set: protocol not supported\n"
I'm trying again with some more logging added to see if I can figure out where the error is actually coming from.
|
The binary works when copied to my IPv6 env: |
node-ip is a subcommand that allows the user to see which IP should the node use in cases of multiple interface and multiple address nodes. This is useful to prevent cases where Container Runtime related services bind to an interface that is not reachable in the control plane. It has two subcommands: * show: Takes one or more Virtual IPs of the control plane and it gives you one eligible IP on stdout. * set: Takes one or more Virtual IPs of the control plane and sets systemd service configuration for services like CRI-O or Kubelet that need to bind to the control plane. In the process of making the commit, and to make runtimecfg less of a monolith, I split its subcommands to separate files.
|
verified to work on both masters and workers. |
|
/retest |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bcrochet, celebdor, cybertron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-ip is a subcommand that allows the user to see which IP should the
node use in cases of multiple interface and multiple address nodes. This
is useful to prevent cases where Container Runtime related services bind
to an interface that is not reachable in the control plane.
It has two subcommands:
show: Takes one or more Virtual IPs of the control plane and it gives
you one eligible IP on stdout.
set: Takes one or more Virtual IPs of the control plane and sets
systemd service configuration for services like CRI-O or Kubelet that
need to bind to the control plane.
In the process of making the commit, and to make runtimecfg less of a
monolith, I split its subcommands to separate files.