Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1821720: Move haproxy listening port due to conflict #59

Merged
merged 1 commit into from Apr 30, 2020

Conversation

mandre
Copy link
Member

@mandre mandre commented Apr 28, 2020

The "Recovering from expired control plane certificates" procedure [1]
stands up a recovery API server on port 7443 [2], conflicting with the
port the haproxy process is listening on.

This patch moves the haproxy port to 9443 instead.

[1] https://docs.openshift.com/container-platform/4.3/backup_and_restore/disaster_recovery/scenario-3-expired-certs.html

[2] https://github.com/openshift/cluster-kube-apiserver-operator/blob/3161546a248f20eb67231017d0ae43c245bfa4cb/pkg/recovery/apiserver.go#L307

The "Recovering from expired control plane certificates" procedure [1]
stands up a recovery API server on port 7443 [2], conflicting with the
port the haproxy process is listening on.

This patch moves the haproxy port to 9443 instead.

[1] https://docs.openshift.com/container-platform/4.3/backup_and_restore/disaster_recovery/scenario-3-expired-certs.html

[2] https://github.com/openshift/cluster-kube-apiserver-operator/blob/3161546a248f20eb67231017d0ae43c245bfa4cb/pkg/recovery/apiserver.go#L307
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 28, 2020
@openshift-ci-robot
Copy link
Contributor

@mandre: This pull request references Bugzilla bug 1821720, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1821720: Move haproxy listening port due to conflict

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre
Copy link
Member Author

mandre commented Apr 29, 2020

/retest

@cybertron
Copy link
Member

/lgtm
/retest

Job failed deploying masters, which seems unlikely to be related to this.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2020
@openshift-merge-robot openshift-merge-robot merged commit f5e6d6b into openshift:master Apr 30, 2020
@openshift-ci-robot
Copy link
Contributor

@mandre: All pull requests linked via external trackers have merged: openshift/baremetal-runtimecfg#59. Bugzilla bug 1821720 has been moved to the MODIFIED state.

In response to this:

Bug 1821720: Move haproxy listening port due to conflict

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre
Copy link
Member Author

mandre commented May 4, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot

@mandre: #59 failed to apply on top of branch "release-4.4":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	cmd/monitor/monitor.go
A	cmd/runtimecfg/display.go
A	cmd/runtimecfg/render.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): cmd/runtimecfg/render.go deleted in HEAD and modified in Bug 1821720: Move haproxy listening port due to conflict. Version Bug 1821720: Move haproxy listening port due to conflict of cmd/runtimecfg/render.go left in tree.
CONFLICT (modify/delete): cmd/runtimecfg/display.go deleted in HEAD and modified in Bug 1821720: Move haproxy listening port due to conflict. Version Bug 1821720: Move haproxy listening port due to conflict of cmd/runtimecfg/display.go left in tree.
Auto-merging cmd/monitor/monitor.go
Patch failed at 0001 Bug 1821720: Move haproxy listening port due to conflict

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Gal-Zaidman pushed a commit to Gal-Zaidman/cluster-kube-controller-manager-operator that referenced this pull request Jul 7, 2020
PR[1] added logic for checking port availability in recovery-controller.
PR[2] change the port of HAProxy to 9443, due to yet another port conflict.
Both of the PRs cause the kube-controller-manager-recovery-controller to crash loop
on on-prem platforms such as oVirt, baremetal and openstack.
This PR changes the port ov the recovery controller.

[1] openshift#421
[2] openshift/baremetal-runtimecfg#59

Signed-off-by: Gal-Zaidman <gzaidman@redhat.com>
Gal-Zaidman pushed a commit to Gal-Zaidman/baremetal-runtimecfg that referenced this pull request Jul 7, 2020
… KCM

HAProxy port was moved on [1] to 9443, this cinflicted with KCM recovery container
which is using 9443 since 4.3. on [2] KCM added a check that the port is free which
caused a conflict and a crashlooping pod.

[1] openshift#59
[2] openshift/cluster-kube-controller-manager-operator#421

Signed-off-by: Gal-Zaidman <gzaidman@redhat.com>
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/baremetal-runtimecfg that referenced this pull request Jul 18, 2020
… KCM

HAProxy port was moved on [1] to 9443, this cinflicted with KCM recovery container
which is using 9443 since 4.3. on [2] KCM added a check that the port is free which
caused a conflict and a crashlooping pod.

[1] openshift#59
[2] openshift/cluster-kube-controller-manager-operator#421

Signed-off-by: Gal-Zaidman <gzaidman@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants