Add A/AAAA record types for VIP DNS entries #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
celebdor
requested changes
Apr 29, 2020
We add records for some of the VIPs to our internal coredns server. These records need to be of the appropriate type for the ip version used. This change adds record type fields to the cluster for use in the coredns config file. Two fields are added for each VIP: One that specifies the correct type of record, and one that specifies the other so that we are able to correctly handle requests for the wrong record type too.
cybertron
force-pushed
the
vip-record-types
branch
from
2f7bce9
to
4691e53
Compare
celebdor
approved these changes
Apr 29, 2020
|
/retest |
|
/retest packet host never came up |
|
/retest |
|
/retest It's failing progressively faster each time... |
|
/retest |
|
/retest Never deployed masters |
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: celebdor, cybertron, yboaron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test e2e-metal-ipi |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
cybertron
added a commit
to cybertron/machine-config-operator
that referenced
this pull request
Jun 4, 2020
Previously the ingress record was hard-coded to be an A record, which does not work when deploying with an ipv6 ingress VIP. While fixing that, an issue with the api and api-int records was also exposed. According to RFC 4074, when a query for a record comes in that asks for the wrong type of record (i.e. asking for an A record when only a AAAA record exists), the server should return NOERROR with an empty list of records. This indicates to the client resolver that a record of that name exists, but not with that type. For our purposes, it was necessary to convert all of the records to use the template plugin in order to get this behavior. The hosts plugin previously used for the api records does not correctly handle requests for the wrong record type, at least with the fallthrough option that we also need. The file plugin, which does correctly handle requests for the wrong record type, has a different issue. We want to allow external records in the same subdomain (and this is necessary for development purposes), but there is no way to make the file plugin forward requests it can't handle. To make the template plugin behave correctly, two entries are needed for each record: one with the correct type and the appropriate answer, and one with the incorrect type and an empty answer. This gets us RFC-compliant behavior while still allowing fallthrough for requests that are not present in the local server. This change requires new fields from baremetal-runtimecfg that are added in openshift/baremetal-runtimecfg#60.
|
/cherry-pick release-4.5 |
|
@cybertron: new pull request created: #69 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cybertron
added a commit
to cybertron/machine-config-operator
that referenced
this pull request
Jun 24, 2020
Previously the ingress record was hard-coded to be an A record, which does not work when deploying with an ipv6 ingress VIP. While fixing that, an issue with the api and api-int records was also exposed. According to RFC 4074, when a query for a record comes in that asks for the wrong type of record (i.e. asking for an A record when only a AAAA record exists), the server should return NOERROR with an empty list of records. This indicates to the client resolver that a record of that name exists, but not with that type. For our purposes, it was necessary to convert all of the records to use the template plugin in order to get this behavior. The hosts plugin previously used for the api records does not correctly handle requests for the wrong record type, at least with the fallthrough option that we also need. The file plugin, which does correctly handle requests for the wrong record type, has a different issue. We want to allow external records in the same subdomain (and this is necessary for development purposes), but there is no way to make the file plugin forward requests it can't handle. To make the template plugin behave correctly, two entries are needed for each record: one with the correct type and the appropriate answer, and one with the incorrect type and an empty answer. This gets us RFC-compliant behavior while still allowing fallthrough for requests that are not present in the local server. This change requires new fields from baremetal-runtimecfg that are added in openshift/baremetal-runtimecfg#60.
vrutkovs
pushed a commit
to vrutkovs/machine-config-operator
that referenced
this pull request
Jul 30, 2020
Previously the ingress record was hard-coded to be an A record, which does not work when deploying with an ipv6 ingress VIP. While fixing that, an issue with the api and api-int records was also exposed. According to RFC 4074, when a query for a record comes in that asks for the wrong type of record (i.e. asking for an A record when only a AAAA record exists), the server should return NOERROR with an empty list of records. This indicates to the client resolver that a record of that name exists, but not with that type. For our purposes, it was necessary to convert all of the records to use the template plugin in order to get this behavior. The hosts plugin previously used for the api records does not correctly handle requests for the wrong record type, at least with the fallthrough option that we also need. The file plugin, which does correctly handle requests for the wrong record type, has a different issue. We want to allow external records in the same subdomain (and this is necessary for development purposes), but there is no way to make the file plugin forward requests it can't handle. To make the template plugin behave correctly, two entries are needed for each record: one with the correct type and the appropriate answer, and one with the incorrect type and an empty answer. This gets us RFC-compliant behavior while still allowing fallthrough for requests that are not present in the local server. This change requires new fields from baremetal-runtimecfg that are added in openshift/baremetal-runtimecfg#60.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add records for some of the VIPs to our internal coredns server.
These records need to be of the appropriate type for the ip version
used. This change adds record type fields to the cluster for use
in the coredns config file. Two fields are added for each VIP:
One that specifies the correct type of record, and one that specifies
the other so that we are able to correctly handle requests for the
wrong record type too.