Bug 1840222: Fail if no upstream DNS servers are found #63
Conversation
Coredns will fail to start if we configure the forward plugin with no upstream servers. The init container responsible for rendering the config needs to fail if that situation arises so it can be retried later when hopefully resolv.conf has been populated correctly. We're not sure how it happens that there are no upstream servers, but it's clearly wrong for us to render an invalid config so this is the safe thing to do anyway.
openshift-ci-robot
added
bugzilla/severity-urgent
|
@cybertron: This pull request references Bugzilla bug 1840222, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
|
Looks like we had a problem mirroring the release: /test e2e-metal-ipi |
|
/hold Please don't lgtm yet, want to see how e2e-metal-ipi job does |
openshift-ci-robot
added
the
do-not-merge/hold
|
Passed! That's encouraging. /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bcrochet, cybertron, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.4 |
|
@stbenjam: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@cybertron: All pull requests linked via external trackers have merged: openshift/baremetal-runtimecfg#63. Bugzilla bug 1840222 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@stbenjam: new pull request created: #64 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Coredns will fail to start if we configure the forward plugin with
no upstream servers. The init container responsible for rendering
the config needs to fail if that situation arises so it can be
retried later when hopefully resolv.conf has been populated correctly.
We're not sure how it happens that there are no upstream servers,
but it's clearly wrong for us to render an invalid config so this
is the safe thing to do anyway.