New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug 1911211: Prefer OS_GIT_VERSION over SOURCE_GIT_TAG when getting build version #30
bug 1911211: Prefer OS_GIT_VERSION over SOURCE_GIT_TAG when getting build version #30
Conversation
When ART builds an image, it copies the content of the source (github) repo into a production repo, and builds from that. The added SOURCE_GIT_* vars in Dockerfile are intended to relay the state of the *original* source repo, in case that is important at build or runtime. To get the production version, one needs to read OS_GIT_VERSION instead.
@ingvagabund: This pull request references Bugzilla bug 1911211, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ingvagabund: This pull request references Bugzilla bug 1911211, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
@ingvagabund: This pull request references Bugzilla bug 1911211, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@ingvagabund: This pull request references Bugzilla bug 1911211, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold cancel |
No, we usually have a separate variable reflecting that information, for example: https://github.com/openshift/oc/blob/6352e607f262df44964a63004f85d81366accbbc/Makefile#L16-L18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ingvagabund: All pull requests linked via external trackers have merged: Bugzilla bug 1911211 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When ART builds an image, it copies the content of the source (github) repo into a production repo, and builds from that. The added SOURCE_GIT_* vars in Dockerfile are intended to relay the state of the original source repo, in case that is important at build or runtime.
To get the production version, one needs to read OS_GIT_VERSION instead.
Before:
After:
/hold
Waiting for 4.8 time frame
We should check if this change is sane for any consumer. One might be relying on
SOURCE_GIT_TAG
actually to have the upstream format.