fix verify-deps always returning 1 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
tnozicka
reviewed
Feb 11, 2020
| @@ -15,8 +15,7 @@ endef | |||
| verify-deps: tmp_dir:=$(shell mktemp -d) | |||
| verify-deps: | |||
| $(call restore-deps,$(tmp_dir)) | |||
| $(deps_diff) "$(tmp_dir)"/{current,updated}/go.mod || echo '`go.mod` content is incorrect - did you run `go mod tidy`?' && false | |||
| $(deps_diff) "$(tmp_dir)"/{current,updated}/go.sum || echo '`go.sum` content is incorrect - did you run `go mod tidy`?' && false | |||
There was a problem hiding this comment.
why removing the go.sum check?
There was a problem hiding this comment.
added it back, did not notice it was checking as different file, my bad
stlaz
force-pushed
the
verify_deps_fix
branch
from
6560f13
to
7c241a8
Compare
stlaz
force-pushed
the
verify_deps_fix
branch
from
7c241a8
to
d30356a
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stlaz, tnozicka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/assign @tnozicka