Bug 1774492: turn off forcepull after the special incremental/forcepull pre-build …

[gabemontero]

…one off

/assign @adambkaplan
/assign @bparees

this replaces the OCM PR I just closed.

[openshift-ci-robot]

@gabemontero: This pull request references Bugzilla bug 1774492, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1774492: turn off forcepull after the special incremental/forcepull pre-build …

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gabemontero]

when reviewing the bug I would suggest expanding the view so you see up to line 240 of the changed file @adambkaplan @bparees

[gabemontero]

verified locally via

1. used BC of

apiVersion: build.openshift.io/v1
kind: BuildConfig
metadata:
  name: sti
spec:
  output:
    to:
      kind: ImageStreamTag
      name: sti:latest
  postCommit: {}
  resources: {}
  runPolicy: Serial
  source:
    binary: {}
    type: Binary
  strategy:
    sourceStrategy:
      forcePull: true
      from:
        kind: DockerImage
        name: registry.redhat.io/openjdk/openjdk-11-rhel8:latest
      incremental: true
    type: Source

2. created a secret for my registry.redhat.io credentials
3. linked the secret to the default and builder SAs
4. ran the build from my local clone of the openshift jenkins plugin maven/java based repo (as the binary build input)

an extended test following a similar pattern and using the installer pull creds seems possible, where we clone a java repo and then do a binary build from it ... or we come up with a non-binary build example.

[adambkaplan]

/lgtm

[bparees]

/hold

i want to better understand this first

[bparees]

/hold cancel
/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, bparees, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adambkaplan,bparees]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gabemontero]

terraform / aws hoopla for e2e-aws and e2e-aws-image-eco

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[gabemontero]

same with the e2e-aws-builds

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@gabemontero: All pull requests linked via external trackers have merged. Bugzilla bug 1774492 has been moved to the MODIFIED state.

In response to this:

Bug 1774492: turn off forcepull after the special incremental/forcepull pre-build …

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.