Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump containers/storage to v1.20.2 #164

Merged
merged 1 commit into from Jul 22, 2020

Conversation

otaviof
Copy link
Member

@otaviof otaviof commented Jul 17, 2020

Updating containers/storage to v1.20.2 in order to support using node's layers mounted on build pods. As per PR #126 in openshift/openshift-controller-manager.

Bumping containers/storage needs newer buildah, which are currently in master, plus minor refactoring on capturing error from Capabilities parsing.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 17, 2020
@openshift-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@otaviof otaviof changed the title Bump containers/storage to v1.20.2 Bump containers/storage to v1.20.2 Jul 17, 2020
@otaviof
Copy link
Member Author

otaviof commented Jul 17, 2020

@adambkaplan, @gabemontero, @nalind, please consider.

@otaviof
Copy link
Member Author

otaviof commented Jul 17, 2020

/test all

pkg/build/builder/source.go Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
@otaviof otaviof force-pushed the BUILD-75 branch 2 times, most recently from 8f034a4 to 1d0f361 Compare July 18, 2020 06:42
go.sum Show resolved Hide resolved
@otaviof
Copy link
Member Author

otaviof commented Jul 18, 2020

/test all

@otaviof otaviof marked this pull request as ready for review July 21, 2020 08:23
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2020
@otaviof
Copy link
Member Author

otaviof commented Jul 21, 2020

/retest

1 similar comment
@otaviof
Copy link
Member Author

otaviof commented Jul 21, 2020

/retest

@otaviof
Copy link
Member Author

otaviof commented Jul 21, 2020

/test e2e-aws

@otaviof
Copy link
Member Author

otaviof commented Jul 21, 2020

/test e2e-aws-image-ecosystem

@rhatdan
Copy link
Contributor

rhatdan commented Jul 22, 2020

/approve
LGTM
@nalind PTAL

@rhatdan
Copy link
Contributor

rhatdan commented Jul 22, 2020

@adambkaplan PTAL

Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a minor issue with our containerd pin. Othwerise looks good.

vendor/modules.txt Outdated Show resolved Hide resolved
Upgrading `containers/storage` to `v1.20.2` in order to support
extracting layers from node storage (via `hostPath` mount).
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, otaviof, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2020
@openshift-merge-robot openshift-merge-robot merged commit 7b85785 into openshift:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants