Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1876913: Configure proxy via git config #174

Merged
merged 2 commits into from Sep 9, 2020
Merged

Bug 1876913: Configure proxy via git config #174

merged 2 commits into from Sep 9, 2020

Conversation

adambkaplan
Copy link
Contributor

Configure HTTP/HTTPS proxy using git command line, rather than environment variables. This is a work-around for BZ 1875639.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 8, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2020
@adambkaplan adambkaplan mentioned this pull request Sep 8, 2020
Merged
@adambkaplan adambkaplan changed the title WIP - Fix git proxy config Bug 1876913: Configure proxy via git config Sep 8, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 8, 2020
@openshift-ci-robot
Copy link
Contributor

@adambkaplan: This pull request references Bugzilla bug 1876913, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1876913: Configure proxy via git config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 8, 2020
@adambkaplan
Copy link
Contributor Author

/test e2e-aws-proxy

@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 8, 2020
Merged
@otaviof
Copy link
Member

otaviof commented Sep 9, 2020

/test e2e-aws-proxy
/test e2e-aws-builds

otaviof
otaviof reviewed Sep 9, 2020
View reviewed changes
go.mod
github.com/fsouza/go-dockerclient v1.6.3
github.com/opencontainers/runc v1.0.0-rc91.0.20200707015106-819fcc687efb
github.com/opencontainers/runtime-spec v1.0.3-0.20200520003142-237cc4f519e2
github.com/openshift/api v0.0.0-20200326160804-ecb9283fe820
github.com/openshift/client-go v0.0.0-20200326155132-2a6cd50aedd0
github.com/openshift/api v0.0.0-20200827090112-c05698d102cf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the changes in go.mod related to the "no proxy" issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This came in from the bump to library-go.

@adambkaplan adambkaplan mentioned this pull request Sep 9, 2020
Merged
@adambkaplan adambkaplan changed the title Bug 1876913: Configure proxy via git config WIP - Bug 1876913: Configure proxy via git config Sep 9, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2020
@adambkaplan
Copy link
Contributor Author

/test e2e-aws-proxy

@adambkaplan
bump(*):
1d92cbe 
- github.com/openshift/library-go to @master (1d055d971916)
- github.com/openshift/<api, client-go) bumps
- k8s.io/* to v0.19.0
- k8s.io/klog/v2 to v2.3.0
- go mod tidy && go mod vendor
@adambkaplan
Bug 1876913: Configure proxy via git config
3d4a3a4 
Configure HTTP/HTTPS proxy using git command line, rather than
environment variables. This is a work-around for
[BZ 1875639](https://bugzilla.redhat.com/show_bug.cgi?id=1875639).
@adambkaplan adambkaplan changed the title WIP - Bug 1876913: Configure proxy via git config Bug 1876913: Configure proxy via git config Sep 9, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2020
adambkaplan
adambkaplan commented Sep 9, 2020
View reviewed changes
Copy link
Contributor Author

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @gabemontero

/cc @coreydaley @otaviof

@adambkaplan
Copy link
Contributor Author

/test e2e-aws-proxy

@gabemontero
Copy link
Contributor

/lgtm

@adambkaplan presumably when this lands, in addition to the immediate concerns, in theory we've pulled in requisite git fixes to satisfy https://issues.redhat.com/browse/BUILD-68 as well

I would suggest we move that story to on-qe in our first 4.7 sprint for @wewang58 to try out

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gabemontero gabemontero mentioned this pull request Sep 9, 2020
Closed
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6715074 into openshift:master Sep 9, 2020
@openshift-ci-robot
Copy link
Contributor

@adambkaplan: All pull requests linked via external trackers have merged:

Bugzilla bug 1876913 has been moved to the MODIFIED state.

In response to this:

Bug 1876913: Configure proxy via git config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreydaley coreydaley Awaiting requested review from coreydaley

@gabemontero gabemontero Awaiting requested review from gabemontero

@otaviof otaviof Awaiting requested review from otaviof

Assignees

@gabemontero gabemontero

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@adambkaplan @openshift-ci-robot @otaviof @gabemontero @openshift-bot @openshift-merge-robot