Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.6] Bug 1901512: Fix private git clones behind a proxy #192

Merged
merged 2 commits into from Nov 27, 2020
Merged

[release-4.6] Bug 1901512: Fix private git clones behind a proxy #192

merged 2 commits into from Nov 27, 2020

Conversation

adambkaplan
Copy link
Contributor

Manual cherry-pick of #189, due to library-go bump.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. labels Nov 25, 2020
@openshift-ci-robot
Copy link
Contributor

@adambkaplan: This pull request references Bugzilla bug 1901512, which is invalid:

  • expected dependent Bugzilla bug 1896446 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

WIP - [release-4.6] Bug 1901512: Fix private git clones behind a proxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 25, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2020
@mfojtik
Copy link
Member

mfojtik commented Nov 26, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 26, 2020
@openshift-ci-robot
Copy link
Contributor

@mfojtik: This pull request references Bugzilla bug 1901512, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1896446 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1896446 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik
Copy link
Member

mfojtik commented Nov 26, 2020

/retest

@openshift-ci-robot openshift-ci-robot mentioned this pull request Nov 26, 2020
Merged
@adambkaplan
bump(github.com/openshift/library-go):
f5ed8e6 
- Allows the default .gitconfig to be updated
@adambkaplan
Bug 1896446: Fix private git clones behind a proxy
a18dec5 
Switch between the "default" and global git configuration depending if a
.gitconfig file has been generated:

- Use the "default" .gitconfig specified by the GIT_CONFIG environment variable
  if a git configuration file was generated when source secrets were used to
  initialize the git envrionment.
- Use the global .gitconfig if no source secret was set up.
- Updated godoc to indicate when a .gitconfig file was generated and return values
  for setupGitEnvironment.
- Add missing methods to the SCMAuthContext interface. Update functions
to return SCMAuthContext interfaces.
- Add test package for unit test framework code
@adambkaplan adambkaplan changed the title WIP - [release-4.6] Bug 1901512: Fix private git clones behind a proxy [release-4.6] Bug 1901512: Fix private git clones behind a proxy Nov 26, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 26, 2020
@mfojtik mfojtik added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 26, 2020
@mfojtik
Copy link
Member

mfojtik commented Nov 26, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@xiuwang
Copy link

xiuwang commented Nov 27, 2020

/bugzilla cc-qa

@openshift-ci-robot
Copy link
Contributor

@xiuwang: This pull request references Bugzilla bug 1901512, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1896446 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1896446 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
  • bug has dependents

Requesting review from QA contact:
/cc @xiuwang

In response to this:

/bugzilla cc-qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xiuwang
Copy link

xiuwang commented Nov 27, 2020

Test on proxy cluster built from #192.

Test source secret with .gitconfig file , build could pull code from private repo. Builds go to completed.
Test source secret with basic auth, build could pull code from private repo. Builds go to completed.
Basic HTTP auth, github.com added to NO_PROXY. Times out cloning source (cannot access github.com)

@xiuwang
Copy link

xiuwang commented Nov 27, 2020

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, mfojtik, xiuwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7a2efbf into openshift:release-4.6 Nov 27, 2020
@openshift-ci-robot
Copy link
Contributor

@adambkaplan: All pull requests linked via external trackers have merged:

Bugzilla bug 1901512 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1901512: Fix private git clones behind a proxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreydaley coreydaley Awaiting requested review from coreydaley

@gabemontero gabemontero Awaiting requested review from gabemontero

@xiuwang xiuwang Awaiting requested review from xiuwang

Assignees

@mfojtik mfojtik

@xiuwang xiuwang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@adambkaplan @openshift-ci-robot @mfojtik @openshift-bot @xiuwang @openshift-merge-robot