Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1908361: BUILD-150: bump(*): k8s 1.20.0 #197

Merged
merged 1 commit into from Dec 16, 2020
Merged

Bug 1908361: BUILD-150: bump(*): k8s 1.20.0 #197

merged 1 commit into from Dec 16, 2020

Conversation

coreydaley
Copy link
Member

bump(*)

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2020
@coreydaley
Copy link
Member Author

/hold
Updated to release candidate, will update to release once it it ready.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2020
@coreydaley
Copy link
Member Author

/retest

@coreydaley coreydaley changed the title [WIP] BUILD-150: bump(*): k8s 1.20.1-rc.0 [WIP] BUILD-150: bump(*): k8s 1.20.0 Dec 14, 2020
@coreydaley
Copy link
Member Author

/assign @adambkaplan @gabemontero

@coreydaley
Copy link
Member Author

/retest

@coreydaley coreydaley changed the title [WIP] BUILD-150: bump(*): k8s 1.20.0 BUILD-150: bump(*): k8s 1.20.0 Dec 15, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 15, 2020
@coreydaley
Copy link
Member Author

/retest
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 15, 2020
@coreydaley
Copy link
Member Author

/retest

@coreydaley coreydaley changed the title BUILD-150: bump(*): k8s 1.20.0 Bug 1908361: BUILD-150: bump(*): k8s 1.20.0 Dec 16, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 16, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 16, 2020 •
edited

@coreydaley: This pull request references Bugzilla bug 1908361, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1908361: BUILD-150: bump(*): k8s 1.20.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adambkaplan
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2020
adambkaplan
adambkaplan requested changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit comment nit - please indicate that you are bumping k8s dependencies to v1.20.0 in the body.

Otherwise looks good.

@openshift-ci-robot openshift-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2020
@coreydaley
Copy link
Member Author

@adambkaplan commit message updated

@coreydaley coreydaley force-pushed the rebase_kube_1_20 branch 2 times, most recently from 9d6d395 to e6db012 Compare December 16, 2020 14:42
@gabemontero
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2020
adambkaplan
adambkaplan approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, coreydaley, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2020
@openshift-merge-robot openshift-merge-robot merged commit 8504b3f into openshift:master Dec 16, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 16, 2020 •
edited

@coreydaley: All pull requests linked via external trackers have merged:

Bugzilla bug 1908361 has been moved to the MODIFIED state.

In response to this:

Bug 1908361: BUILD-150: bump(*): k8s 1.20.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@gabemontero gabemontero Awaiting requested review from gabemontero

Assignees

@adambkaplan adambkaplan

@gabemontero gabemontero

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@coreydaley @openshift-ci-robot @adambkaplan @gabemontero @openshift-merge-robot