Bug 1918153: incorrect escaping of HTML symbols in envars

[alicerum]

When building from source using docker strategy, keys and values for environment variables from BuildConfig and labels have been marshalled to json strings to put them in quotes and do escaping.
Problem was, this marshalling also escapes HTML symbols <>&, which should be allowed for environment variables and labels.
Solution is to process values with strconv.Quote function in order to escape only non-printable and control characters.

With the BuildConfig provided in Bugzilla, and my changes I get this result:

wyvie@irum-mac ~/go/src/github.com/openshift/builder (fix-build-envars-character-escaping*) $ oc logs -f bc/docker-build
...
STEP 1: FROM quay.io/generic/rhel7:latest
STEP 2: ENV "IncorrectURLFromENV"="http://abc.com/q?key1=value1&key2=value2"
...
STEP 5: ENV CorrectURLFromDockerFile='https://abc123.com/q?key1=value1&key2=value2'
--> b74c4ad1b71
...
STEP 10: LABEL "io.openshift.build.commit.author"="Rejeeb <54980000+rejeeb786@users.noreply.github.com>" "io.openshift.build.commit.date"="Wed Jan 20 07:34:30 2021 +0530" "io.openshift.build.commit.id"="b83aaf78858b7a8e970a52a07e06dfb3bb7e7ecc" "io.openshift.build.commit.message"="Update Dockerfile" "io.openshift.build.commit.ref"="main" "io.openshift.build.name"="docker-[build-1](https://issues.redhat.com/browse/build-1)" "io.openshift.build.namespace"="testing" "io.openshift.build.source-context-dir"="/" "io.openshift.build.source-location"="https://github.com/rejeeb786/test.git"
...

[openshift-ci-robot]

@alicerum: This pull request references Bugzilla bug 1918153, which is invalid:

• expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1918153: incorrect escaping of HTML symbols in envars

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[otaviof]

/retest

[openshift-ci-robot]

@alicerum: This pull request references Bugzilla bug 1918153, which is invalid:

• expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1918153: incorrect escaping of HTML symbols in envars

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@alicerum: This pull request references Bugzilla bug 1918153, which is invalid:

• expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1918153: incorrect escaping of HTML symbols in envars

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[alicerum]

/retest

[gabemontero]

hey @alicerum - has your "onramping" progressed enough that you understand what is up with the bugzilla integration requirements as noted in #215 (comment)

and the OWNERS file requirements as noted in #215 (comment) ?

If not let us know and we can discuss either here or in scrum

[alicerum]

If not let us know

Letting you know! Discussing in scrum (or after) would be beneficial.

[alicerum]

/bugzilla refresh

[openshift-ci-robot]

@alicerum: This pull request references Bugzilla bug 1918153, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wewang58]

/bugzilla cc-qa

[openshift-ci-robot]

@wewang58: This pull request references Bugzilla bug 1918153, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wewang58

In response to this:

/bugzilla cc-qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wewang58]

/lgtm
Launched a cluster using cluster-bot, verified it
STEP 1: FROM quay.io/generic/rhel7:latest
STEP 2: ENV "IncorrectURLFromENV"="http://abc.com/q?key1=value1&key2=value2"
--> 546b155da6f
STEP 3: MAINTAINER aPaaS : Rejeeb
--> e8b0bc8dcb3
STEP 4: USER root
--> 0efc16f019c
STEP 5: ENV CorrectURLFromDockerFile='https://abc123.com/q?key1=value1&key2=value2'

[adambkaplan]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, alicerum, wewang58

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adambkaplan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@alicerum: All pull requests linked via external trackers have merged:

• openshift/builder#215

Bugzilla bug 1918153 has been moved to the MODIFIED state.

In response to this:

Bug 1918153: incorrect escaping of HTML symbols in envars

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pradeepto]

Congratulations @alicerum \o/

Great start!