Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OWNERS file #260

Merged
merged 1 commit into from Aug 25, 2021
Merged

Update OWNERS file #260

merged 1 commit into from Aug 25, 2021

Conversation

coreydaley
Copy link
Member

Add coreydaley as an approver

@coreydaley
Update OWNERS file
597a010 
Add coreydaley as an approver
@coreydaley
Copy link
Member Author

/assign @adambkaplan

adambkaplan
adambkaplan approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

🎉

@adambkaplan
Copy link
Contributor

/label docs-approved

no doc

@adambkaplan
Copy link
Contributor

/label qe-approved

no qe

@adambkaplan
Copy link
Contributor

/label px-approved

no px

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR lgtm Indicates that a PR is ready to be merged. docs-approved Signifies that Docs has signed off on this PR labels Aug 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, coreydaley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 25, 2021
@openshift-merge-robot openshift-merge-robot merged commit 50d5b91 into openshift:master Aug 25, 2021
@coreydaley
Copy link
Member Author

/cherry-pick release-4.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 14, 2022
Merged
@openshift-cherrypick-robot
Copy link

@coreydaley: new pull request created: #290

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@gabemontero gabemontero Awaiting requested review from gabemontero

Assignees

@adambkaplan adambkaplan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@coreydaley @adambkaplan @openshift-cherrypick-robot @openshift-merge-robot