Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.9] Bug 2037776: Update containers/storage to address incorrect overlay options being set on rhel7 nodes #279

Merged
merged 1 commit into from Jan 7, 2022
Merged

[release-4.9] Bug 2037776: Update containers/storage to address incorrect overlay options being set on rhel7 nodes #279

merged 1 commit into from Jan 7, 2022

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #275

/assign adambkaplan

@nalind
bump github.com/containers/storage, /image
defce1b 
Bump github.com/containers/storage to have it correctly diagnose when
globally-set options will cause problems for the overlay driver.
Bump github.com/containers/image to v5.16.1.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 6, 2022
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 6, 2022

@openshift-cherrypick-robot: Bugzilla bug 1979966 has been cloned as Bugzilla bug 2037776. Retitling PR to link against new bug.
/retitle [release-4.9] Bug 2037776: Update containers/storage to address incorrect overlay options being set on rhel7 nodes

In response to this:

[release-4.9] Bug 1979966: Update containers/storage to address incorrect overlay options being set on rhel7 nodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.9] Bug 1979966: Update containers/storage to address incorrect overlay options being set on rhel7 nodes [release-4.9] Bug 2037776: Update containers/storage to address incorrect overlay options being set on rhel7 nodes Jan 6, 2022
@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jan 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 6, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2037776, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1979966 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1979966 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
  • bug has dependents

Requesting review from QA contact:
/cc @jitendar-singh

In response to this:

[release-4.9] Bug 2037776: Update containers/storage to address incorrect overlay options being set on rhel7 nodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 6, 2022
@adambkaplan adambkaplan mentioned this pull request Jan 6, 2022
Closed
@adambkaplan
Copy link
Contributor

/assign @nalind

adambkaplan
adambkaplan approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2022
@adambkaplan
Copy link
Contributor

/label backport-risk-assessed

  • Subjective assessment has been completed and/or the bug has the "FastFix" keyword.
  • Bug qualifies for backport based on priority, severity, and/or customer impact.
  • Release is fully supported OR one of the following:
    • The bug is a critical fix, no reasonable workaround exists, and a recommendation for upgrade has been ruled out.
    • The bug is a security fix.
  • Bug severity reflects criticality.
  • PR is merged in the next newer release and has been VERIFIED by QE OR bug is FastFix and has been verified in the main development branch.
  • PR content is suitable for customers - one of the following:
    • PR was created by the cherry-pick bot.
    • PR has a title and description suitable for end user release notes, including BZ identifier, issue impact, cause, and resolution.

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 6, 2022
@gabemontero
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, gabemontero, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2022
@gabemontero
Copy link
Contributor

/assign @jitendar-singh
/assign @prietyc123

for cherry pick approval label

@nalind
Copy link
Member

nalind commented Jan 6, 2022

Can confirm that this incorporates the desired change in the storage library.

@gabemontero
Copy link
Contributor

@adambkaplan what do you want to do about the broken rhel7 e2e on this one (given this backport is specifically rhel7 related) ... simply override and defer to QE on the verification (especially since we have positive verification in 4.10) ?

@gabemontero
Copy link
Contributor

/test e2e-aws-proxy

apparent AWS flake on the last run

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@adambkaplan
Copy link
Contributor

/override ci/prow/e2e-aws-builds-rhel7

Given that we won't have that rhel7 job fixed soon, we can fall back to having QE verify separately. I'm comfortable doing this now that we have verified the fix in 4.10.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@prietyc123
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 7, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@prietyc123
Copy link

/retest

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@gabemontero
Copy link
Contributor

all the sig-builds tests passed in e2e-aws-proxy, just hit a networking e2e flake in the last run https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_builder/279/pull-ci-openshift-builder-release-4.9-e2e-aws-proxy/1479359240479969280 @adambkaplan @nalind

depending on how eager we are to get this urgent bug in @adambkaplan we might want to override proxy as well as rhel7

/retest

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@adambkaplan
Copy link
Contributor

/override ci/prow/e2e-aws-builds-rhel7

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 7, 2022

@adambkaplan: Overrode contexts on behalf of adambkaplan: ci/prow/e2e-aws-builds-rhel7

In response to this:

/override ci/prow/e2e-aws-builds-rhel7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 7f24588 into openshift:release-4.9 Jan 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 7, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2037776 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2037776: Update containers/storage to address incorrect overlay options being set on rhel7 nodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 7, 2022

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@jitendar-singh jitendar-singh Awaiting requested review from jitendar-singh

@coreydaley coreydaley Awaiting requested review from coreydaley

Assignees

@nalind nalind

@adambkaplan adambkaplan

@gabemontero gabemontero

@jitendar-singh jitendar-singh

@prietyc123 prietyc123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@openshift-cherrypick-robot @adambkaplan @gabemontero @nalind @openshift-bot @prietyc123 @openshift-merge-robot @jitendar-singh