Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump github.com/containers/buildah to v1.26.2 #304

Merged
merged 2 commits into from Jul 31, 2022

Conversation

nalind
Copy link
Member

@nalind nalind commented Jul 18, 2022

Tweak update-deps.sh to call go get -t on the local cmd package and the latest buildah package, and pass -compat=1.17 to go mod tidy to avoid an error result.

Update to the current version of buildah, which pulls in v1.40.3 of the storage library, which notably includes containers/storage#1261.

KATA-1278 is tracking this change for the buildah CLI tool, and since we're using it as a library, we're most likely affected by the problem it fixes. This may not be sufficient for us to avoid problems in that configuration, though. For cases where we have privileges but can't use kernel overlay, we may need to start trying to create /dev/fuse ourselves so that our fuse-overlayfs startup-time checks will succeed.

@coreydaley
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 18, 2022
@nalind
Copy link
Member Author

nalind commented Jul 18, 2022

/retest

1 similar comment
@coreydaley
Copy link
Member

/retest

@coreydaley
Copy link
Member

@nalind
It looks like just one test is failing.
Would your change cause this?

 cgroupv2Val is 
    cat: /sys/fs/cgroup/memory/memory.memsw.limit_in_bytes: No such file or directory
    cgroupv1Val is 
    cat: //sys/fs/cgroup///memory.swap.max: No such file or directory
    cgroupv2Val is 
    cat: /sys/fs/cgroup/cpu,cpuacct/cpu.cfs_quota_us: No such file or directory
    QUOTA=
    cat: /sys/fs/cgroup/cpu,cpuacct/cpu.cfs_quota_us: No such file or directory
    SHARES=
    cat: /sys/fs/cgroup/cpu,cpuacct/cpu.shares: No such file or directory
    PERIOD=
    cat: /sys/fs/cgroup/cpu,cpuacct/cpu.cfs_period_us: No such file or directory

@nalind
Copy link
Member Author

nalind commented Jul 18, 2022

@nalind It looks like just one test is failing. Would your change cause this?

I would hope not, but it bears investigating.

Tweak `hack/update-deps.sh` to call `go get -t` on the local `cmd`
package and the latest buildah package, and pass `-compat=1.17` to `go
mod tidy` to avoid an error.

Update to the current version of buildah, which pulls in v1.40.3 of the
storage library.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
The default for buildah since 1.26.0 has been to create new user
namespaces by default, and we don't need that.

Doing so also causes it to not tell runc to mount the cgroup filesystem
when creating a new cgroup namespace, giving commands the node's
/sys/fs/cgroup instead of a new one for the container.

Force use of the host (or more accurately "host", since we're already in
a container) user namespace to just avoid all of this.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2022

@nalind: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@coreydaley
Copy link
Member

/label docs-approved
/label px-approved
/label qe-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Jul 31, 2022
@coreydaley
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coreydaley, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants