New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.14] OCPBUGS-20409: drop the Overlay setting from transient mounts #360
[release-4.14] OCPBUGS-20409: drop the Overlay setting from transient mounts #360
Conversation
Drop the Overlay flag from the set of flags that we pass in for our transient mounts. We erroneously assumed that it was safe to set the flag on all secrets, but it can't be used, in the sense that we expect it to, when the item to be transiently mounted is not a directory. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@openshift-cherrypick-robot: Jira Issue OCPBUGS-20407 has been cloned as Jira Issue OCPBUGS-20409. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-20409, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
cc @jitendar-singh for QE.
/retest |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: adambkaplan, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5cedc85
into
openshift:release-4.14
@openshift-cherrypick-robot: Jira Issue OCPBUGS-20409: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-20409 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix included in accepted release 4.14.0-0.nightly-2023-10-12-104602 |
This is an automated cherry-pick of #359
/assign nalind