OCPBUGS-9994: Verbosity levels for operator and operand

[swghosh]

• New deployment hook for adding --v argument on the basis of operatorSpec.logLevel
• Update operator log level via --v argument of operator binary

Signed-off-by: Swarup Ghosh swghosh@redhat.com

[openshift-ci-robot]

@swghosh: This pull request references Jira Issue OCPBUGS-9994, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

New deployment hook for adding --v argument on the basis of logLevel in operatorSpec.

Signed-off-by: Swarup Ghosh swghosh@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[swghosh]

/hold
I'll check out another operator like openshift-apiserver-operator to check if the values for --v is identical for Trace and TraceAll levels.

[thejasn]

The bug also mentions operatorLogLevel, are you planning on addressing that in this PR itself?

[swghosh]

The bug also mentions operatorLogLevel, are you planning on addressing that in this PR itself?

Yes, we can do that too; in a separate commit in the same PR.

[swghosh]

/remove-hold

I'll check out another operator like openshift-apiserver-operator to check if the values for --v is identical for Trace and TraceAll levels.

Using implementation of OpenShift API server operator resource's logLevel field as reference, the verbosity values corresponding to each logLevel type is same for the one added in this PR.

xref: https://github.com/openshift/library-go/blob/master/pkg/operator/loglevel/util.go#L14-L27

[swghosh]

/retest-required

[openshift-ci-robot]

@swghosh: This pull request references Jira Issue OCPBUGS-9994, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

• New deployment hook for adding --v argument on the basis of operatorSpec.logLevel.
• Added a func in default_cert_manager_controller to set klog verbosity level at runtime via operatorSpec.operatorLogLevel

Signed-off-by: Swarup Ghosh swghosh@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@swghosh: This pull request references Jira Issue OCPBUGS-9994, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

• New deployment hook for adding --v argument on the basis of operatorSpec.logLevel
• Added a func in default_cert_manager_controller to set klog verbosity level at runtime via operatorSpec.operatorLogLevel

Signed-off-by: Swarup Ghosh swghosh@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[swghosh]

/test all

[swghosh]

/cc @xingxingxia @TrilokGeer

[thejasn]

/assign

[thejasn]

Can you add sample logs of before and after for both the operand and operator? Based on this I want to decide if we want to support operatorLogLevel (via the operator spec) at all.

Since the operator already has

cert-manager-operator/main.go

Line 23 in 70e39c5

pflag.CommandLine.AddGoFlagSet(goflag.CommandLine)

, Is this functional? If yes we should be able to control log level via env variables which can be updated via the subscription.

Assuming the above flow works, I think we can choose not to support the operator logLevel via the cluster scoped resource.

[TrilokGeer]

/jira refresh

[swghosh]

/jira refresh

[openshift-ci-robot]

@swghosh: An error was encountered querying GitHub for users with public email (xxia@redhat.com) for bug OCPBUGS-9994 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message.

Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: connect: connection refused

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[swghosh]

/jira refresh

[openshift-ci-robot]

@swghosh: This pull request references Jira Issue OCPBUGS-9994, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xingxingxia

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[xingxingxia]

This hasn't yet Dev /lgtm label before labeling qe-approved. But anyway, labeling it; would like to do post-merge test since other work (including OCP Auth) items need me :)
/label qe-approved

[openshift-ci]

@swghosh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[swghosh]

/cc @xenolinux
for docs-approved label
/cc @davemulford
for px-approved label

[xenolinux]

/label docs-approved

[thejasn]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: swghosh, thejasn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [thejasn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[davemulford]

/label px-approved

[openshift-ci-robot]

@swghosh: Jira Issue OCPBUGS-9994: All pull requests linked via external trackers have merged:

• openshift/cert-manager-operator#111

Jira Issue OCPBUGS-9994 has been moved to the MODIFIED state.

In response to this:

• New deployment hook for adding --v argument on the basis of operatorSpec.logLevel
• Update operator log level via --v argument of operator binary

Signed-off-by: Swarup Ghosh swghosh@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.