OCPBUGS-8466: Add operand pod label customization

[swghosh]

• API add overrideLabels field to DeploymentConfig of cert-manager controller, cainjector, webhook operands
• custom labels to be be added to through deployment hook

Signed-off-by: Swarup Ghosh swghosh@redhat.com

[openshift-ci-robot]

@swghosh: This pull request references Jira Issue OCPBUGS-8466, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

• API add overrideLabels field to DeploymentConfig of cert-manager controller, cainjector, webhook operands
• custom labels to be be added to through deployment hook

Signed-off-by: Swarup Ghosh swghosh@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[swghosh]

/cc @TrilokGeer @xingxingxia

[thejasn]

Since the logic present here merges the existing labels with the new provided labels, I think we want to some validation before merging. Possibly only allowing labels from certmanager.io?

[thejasn]

/assign

[swghosh]

Since the logic present here merges the existing labels with the new provided labels, I think we want to some validation before merging.

@thejasn
Added a validation that filters out conflicting labels present in deployment.Spec.Selector.MatchLabels to avoid deployment pods being mismatched.

[swghosh]

/jira refresh

[openshift-ci-robot]

@swghosh: This pull request references Jira Issue OCPBUGS-8466, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xingxingxia

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[swghosh]

Since the logic present here merges the existing labels with the new provided labels, I think we want to some validation before merging. Possibly only allowing labels from certmanager.io?

@thejasn
added the withPodLabelsValidateHook() so you could PTAL.

The hook is to ensure we validate and allow only podLabels that should be supported. For now, I've added azure.workload.identity/use label (xref: https://cert-manager.io/docs/configuration/acme/dns01/azuredns/#reconfigure-cert-manager, for Azure Workload Identity support) and we can update the list with other labels on need basis as discussed previously.

[thejasn]

/lgtm
/hold for pre-merge testing

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: swghosh, thejasn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [thejasn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[xingxingxia]

/label qe-approved
Would like to do post-merge test : ) since other work (including OCP Auth) items need me :)

[swghosh]

/remove-hold

[swghosh]

/cc @xenolinux for docs-approved
/cc @davemulford for px-approved

[openshift-ci]

@swghosh: GitHub didn't allow me to request PR reviews from the following users: for.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @xenolinux for docs-approved
/cc @davemulford for px-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[xenolinux]

/label docs-approved

[davemulford]

/label px-approved

[openshift-ci]

@swghosh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@swghosh: Jira Issue OCPBUGS-8466: All pull requests linked via external trackers have merged:

• openshift/cert-manager-operator#112

Jira Issue OCPBUGS-8466 has been moved to the MODIFIED state.

In response to this:

• API add overrideLabels field to DeploymentConfig of cert-manager controller, cainjector, webhook operands
• custom labels to be be added to through deployment hook

Signed-off-by: Swarup Ghosh swghosh@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.