CM-190: Rebase v1.13 #143

swghosh · 2023-09-15T08:22:03Z

[v1.13.0] Rebase Checklist:

go dependencies

go get github.com/cert-manager/cert-manager@v1.13.0
go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@d34bd7aa15055b428bf865851bc420412f3710e6
go mod tidy
go mod vendor

go get github.com/openshift/api@release-4.13
go get github.com/openshift/library-go@release-4.13
go mod tidy
go mod vendor

go get sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
go get sigs.k8s.io/controller-tools/cmd/controller-gen@latest
go get sigs.k8s.io/controller-runtime@latest
go mod tidy
go mod vendor

go get sigs.k8s.io/kustomize/kustomize/v5@latest # required for fixing conflicts while running make bundle
go mod tidy
go mod vendor

go get github.com/cert-manager/cert-manager@v1.13.1
go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@v1.13.1
go mod tidy
go mod vendor

skipRange in CSV
openshift/release CI update related PRs
- operand image mirroring with new tag, Update cert-manager mirroring to latest versions release#43286
- ci pipeline use updated operand image tags, [o/cert-manager-operator] cert-manager-1.13 config updates release#43538
push commit 8472ff44076e12a39b8a082f72f48838846844eb, and tag v1.13.1 to our downstream fork

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog

TODO

openshift-ci-robot · 2023-09-15T08:22:06Z

@swghosh: This pull request references CM-189 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

[v1.13.0] Rebase Checklist:

go dependencies

go get github.com/cert-manager/cert-manager@v1.13.0
go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@d34bd7aa15055b428bf865851bc420412f3710e6
go mod tidy
go mod vendor

go get github.com/openshift/api@release-4.13
go get github.com/openshift/library-go@release-4.13
go mod tidy
go mod vendor

go get sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
go get sigs.k8s.io/controller-tools/cmd/controller-gen@latest
go get sigs.k8s.io/controller-runtime@latest
go mod tidy
go mod vendor

go get sigs.k8s.io/kustomize/kustomize/v5@latest # required for fixing conflicts while running make bundle
go mod tidy
go mod vendor

skipRange in CSV
openshift/release CI update related PRs
- operand image mirroring with new tag
- ci pipeline use updated operand image tags

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog

TODO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-09-15T08:22:13Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci-robot · 2023-09-15T08:43:28Z

@swghosh: This pull request references CM-189 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

[v1.13.0] Rebase Checklist:

go dependencies

go get github.com/cert-manager/cert-manager@v1.13.0
go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@d34bd7aa15055b428bf865851bc420412f3710e6
go mod tidy
go mod vendor

go get github.com/openshift/api@release-4.13
go get github.com/openshift/library-go@release-4.13
go mod tidy
go mod vendor

go get sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
go get sigs.k8s.io/controller-tools/cmd/controller-gen@latest
go get sigs.k8s.io/controller-runtime@latest
go mod tidy
go mod vendor

go get sigs.k8s.io/kustomize/kustomize/v5@latest # required for fixing conflicts while running make bundle
go mod tidy
go mod vendor

skipRange in CSV
openshift/release CI update related PRs
- operand image mirroring with new tag
- ci pipeline use updated operand image tags

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog

TODO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

swghosh · 2023-09-15T08:43:52Z

/cc @thejasn @chiragkyal

openshift-ci-robot · 2023-09-15T08:46:42Z

@swghosh: This pull request references CM-190 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.15.0" version, but no target version was set.

In response to this:

[v1.13.0] Rebase Checklist:

go dependencies

go get github.com/cert-manager/cert-manager@v1.13.0
go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@d34bd7aa15055b428bf865851bc420412f3710e6
go mod tidy
go mod vendor

go get github.com/openshift/api@release-4.13
go get github.com/openshift/library-go@release-4.13
go mod tidy
go mod vendor

go get sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
go get sigs.k8s.io/controller-tools/cmd/controller-gen@latest
go get sigs.k8s.io/controller-runtime@latest
go mod tidy
go mod vendor

go get sigs.k8s.io/kustomize/kustomize/v5@latest # required for fixing conflicts while running make bundle
go mod tidy
go mod vendor

skipRange in CSV
openshift/release CI update related PRs
- operand image mirroring with new tag
- ci pipeline use updated operand image tags

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog

TODO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-09-18T09:44:03Z

@swghosh: This pull request references CM-190 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.15.0" version, but no target version was set.

In response to this:

[v1.13.0] Rebase Checklist:

go dependencies
go get github.com/cert-manager/cert-manager@v1.13.0
go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@d34bd7aa15055b428bf865851bc420412f3710e6
go mod tidy
go mod vendor

go get github.com/openshift/api@release-4.13
go get github.com/openshift/library-go@release-4.13
go mod tidy
go mod vendor

go get sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
go get sigs.k8s.io/controller-tools/cmd/controller-gen@latest
go get sigs.k8s.io/controller-runtime@latest
go mod tidy
go mod vendor

go get sigs.k8s.io/kustomize/kustomize/v5@latest # required for fixing conflicts while running make bundle
go mod tidy
go mod vendor
skipRange in CSV

openshift/release CI update related PRs

operand image mirroring with new tag, Update cert-manager mirroring to latest versions release#43286

ci pipeline use updated operand image tags

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog

TODO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-09-18T11:22:51Z

@swghosh: This pull request references CM-190 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.15.0" version, but no target version was set.

In response to this:

[v1.13.0] Rebase Checklist:

go dependencies
go get github.com/cert-manager/cert-manager@v1.13.0
go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@d34bd7aa15055b428bf865851bc420412f3710e6
go mod tidy
go mod vendor

go get github.com/openshift/api@release-4.13
go get github.com/openshift/library-go@release-4.13
go mod tidy
go mod vendor

go get sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
go get sigs.k8s.io/controller-tools/cmd/controller-gen@latest
go get sigs.k8s.io/controller-runtime@latest
go mod tidy
go mod vendor

go get sigs.k8s.io/kustomize/kustomize/v5@latest # required for fixing conflicts while running make bundle
go mod tidy
go mod vendor
skipRange in CSV

openshift/release CI update related PRs

operand image mirroring with new tag, Update cert-manager mirroring to latest versions release#43286

ci pipeline use updated operand image tags, [o/cert-manager-operator] CI job config updates for 1.12, 1.11 release#43445

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog

TODO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-09-20T09:12:43Z

@swghosh: This pull request references CM-190 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.15.0" version, but no target version was set.

In response to this:

[v1.13.0] Rebase Checklist:

go dependencies
go get github.com/cert-manager/cert-manager@v1.13.0
go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@d34bd7aa15055b428bf865851bc420412f3710e6
go mod tidy
go mod vendor

go get github.com/openshift/api@release-4.13
go get github.com/openshift/library-go@release-4.13
go mod tidy
go mod vendor

go get sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
go get sigs.k8s.io/controller-tools/cmd/controller-gen@latest
go get sigs.k8s.io/controller-runtime@latest
go mod tidy
go mod vendor

go get sigs.k8s.io/kustomize/kustomize/v5@latest # required for fixing conflicts while running make bundle
go mod tidy
go mod vendor
skipRange in CSV

openshift/release CI update related PRs

operand image mirroring with new tag, Update cert-manager mirroring to latest versions release#43286

ci pipeline use updated operand image tags, [o/cert-manager-operator] cert-manager-1.13 config updates release#43538

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog

TODO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

swghosh · 2023-09-20T09:52:16Z

/test all

openshift-ci-robot · 2023-09-20T09:56:18Z

@swghosh: This pull request references CM-190 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.15.0" version, but no target version was set.

In response to this:

[v1.13.0] Rebase Checklist:

go dependencies
go get github.com/cert-manager/cert-manager@v1.13.0
go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@d34bd7aa15055b428bf865851bc420412f3710e6
go mod tidy
go mod vendor

go get github.com/openshift/api@release-4.13
go get github.com/openshift/library-go@release-4.13
go mod tidy
go mod vendor

go get sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
go get sigs.k8s.io/controller-tools/cmd/controller-gen@latest
go get sigs.k8s.io/controller-runtime@latest
go mod tidy
go mod vendor

go get sigs.k8s.io/kustomize/kustomize/v5@latest # required for fixing conflicts while running make bundle
go mod tidy
go mod vendor
skipRange in CSV

openshift/release CI update related PRs

operand image mirroring with new tag, Update cert-manager mirroring to latest versions release#43286

ci pipeline use updated operand image tags, [o/cert-manager-operator] cert-manager-1.13 config updates release#43538

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog

TODO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-09-20T09:56:20Z

@swghosh: This pull request references CM-190 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.15.0" version, but no target version was set.

In response to this:

[v1.13.0] Rebase Checklist:

go dependencies
go get github.com/cert-manager/cert-manager@v1.13.0
go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@d34bd7aa15055b428bf865851bc420412f3710e6
go mod tidy
go mod vendor

go get github.com/openshift/api@release-4.13
go get github.com/openshift/library-go@release-4.13
go mod tidy
go mod vendor

go get sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
go get sigs.k8s.io/controller-tools/cmd/controller-gen@latest
go get sigs.k8s.io/controller-runtime@latest
go mod tidy
go mod vendor

go get sigs.k8s.io/kustomize/kustomize/v5@latest # required for fixing conflicts while running make bundle
go mod tidy
go mod vendor
skipRange in CSV

openshift/release CI update related PRs

operand image mirroring with new tag, Update cert-manager mirroring to latest versions release#43286

ci pipeline use updated operand image tags, [o/cert-manager-operator] cert-manager-1.13 config updates release#43538

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog

TODO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

chiragkyal · 2023-09-20T11:45:42Z

/test all

swghosh · 2023-09-21T13:08:12Z

/cc @lunarwhite @xingxingxia
https://redhat-internal.slack.com/archives/C045YMPKR3M/p1695301658420249
for qe-approved label

openshift-ci-robot · 2023-10-09T15:15:20Z

@swghosh: This pull request references CM-190 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.15.0" version, but no target version was set.

In response to this:

[v1.13.0] Rebase Checklist:

go dependencies
go get github.com/cert-manager/cert-manager@v1.13.0
go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@d34bd7aa15055b428bf865851bc420412f3710e6
go mod tidy
go mod vendor

go get github.com/openshift/api@release-4.13
go get github.com/openshift/library-go@release-4.13
go mod tidy
go mod vendor

go get sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
go get sigs.k8s.io/controller-tools/cmd/controller-gen@latest
go get sigs.k8s.io/controller-runtime@latest
go mod tidy
go mod vendor

go get sigs.k8s.io/kustomize/kustomize/v5@latest # required for fixing conflicts while running make bundle
go mod tidy
go mod vendor

go get github.com/cert-manager/cert-manager@v1.13.1
go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@v1.13.1
go mod tidy
go mod vendor
skipRange in CSV

openshift/release CI update related PRs

operand image mirroring with new tag, Update cert-manager mirroring to latest versions release#43286

ci pipeline use updated operand image tags, [o/cert-manager-operator] cert-manager-1.13 config updates release#43538

push commit e3dd325bd5838c2f54dbe9fdd160a4847ffd1f78, and tag v1.13.1 to our downstream fork

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog

TODO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-10-11T07:46:33Z

@swghosh: This pull request references CM-190 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.15.0" version, but no target version was set.

In response to this:

[v1.13.0] Rebase Checklist:

go dependencies
go get github.com/cert-manager/cert-manager@v1.13.0
go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@d34bd7aa15055b428bf865851bc420412f3710e6
go mod tidy
go mod vendor

go get github.com/openshift/api@release-4.13
go get github.com/openshift/library-go@release-4.13
go mod tidy
go mod vendor

go get sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
go get sigs.k8s.io/controller-tools/cmd/controller-gen@latest
go get sigs.k8s.io/controller-runtime@latest
go mod tidy
go mod vendor

go get sigs.k8s.io/kustomize/kustomize/v5@latest # required for fixing conflicts while running make bundle
go mod tidy
go mod vendor

go get github.com/cert-manager/cert-manager@v1.13.1
go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@v1.13.1
go mod tidy
go mod vendor
skipRange in CSV

openshift/release CI update related PRs

operand image mirroring with new tag, Update cert-manager mirroring to latest versions release#43286

ci pipeline use updated operand image tags, [o/cert-manager-operator] cert-manager-1.13 config updates release#43538

push commit 8472ff44076e12a39b8a082f72f48838846844eb, and tag v1.13.1 to our downstream fork

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog

TODO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

swghosh · 2023-10-17T11:12:18Z

/test all

go.sum

bundle/manifests/cert-manager-operator.clusterserviceversion.yaml

Signed-off-by: Swarup Ghosh <swghosh@redhat.com>

* controller-runtime * controller-tools Signed-off-by: Swarup Ghosh <swghosh@redhat.com>

* required bump to make bundle work without conflicts Signed-off-by: Swarup Ghosh <swghosh@redhat.com>

* make update-with-container - pull upstream manifests * make update-bindata * make bundle -- this now uses kustomize v5, to fix some conflicts Signed-off-by: Swarup Ghosh <swghosh@redhat.com>

* make bundle Signed-off-by: Swarup Ghosh <swghosh@redhat.com>

…degen.sh Signed-off-by: Swarup Ghosh <swghosh@redhat.com>

Signed-off-by: Swarup Ghosh <swghosh@redhat.com>

* make update-with-container * make update-bindata * make bundle Signed-off-by: Swarup Ghosh <swghosh@redhat.com>

- make bundle Signed-off-by: Swarup Ghosh <swghosh@redhat.com>

Signed-off-by: Swarup Ghosh <swghosh@redhat.com>

swghosh · 2023-10-18T10:24:36Z

/assign @thejasn
Ti's ready now, finally :)

openshift-ci-robot · 2023-10-18T10:45:56Z

@swghosh: This pull request references CM-190 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.15.0" version, but no target version was set.

In response to this:

[v1.13.0] Rebase Checklist:

go dependencies
go get github.com/cert-manager/cert-manager@v1.13.0
go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@d34bd7aa15055b428bf865851bc420412f3710e6
go mod tidy
go mod vendor

go get github.com/openshift/api@release-4.13
go get github.com/openshift/library-go@release-4.13
go mod tidy
go mod vendor

go get sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
go get sigs.k8s.io/controller-tools/cmd/controller-gen@latest
go get sigs.k8s.io/controller-runtime@latest
go mod tidy
go mod vendor

go get sigs.k8s.io/kustomize/kustomize/v5@latest # required for fixing conflicts while running make bundle
go mod tidy
go mod vendor

go get github.com/cert-manager/cert-manager@v1.13.1
go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@v1.13.1
go mod tidy
go mod vendor
skipRange in CSV

openshift/release CI update related PRs

operand image mirroring with new tag, Update cert-manager mirroring to latest versions release#43286

ci pipeline use updated operand image tags, [o/cert-manager-operator] cert-manager-1.13 config updates release#43538

push commit 8472ff44076e12a39b8a082f72f48838846844eb, and tag v1.13.1 to our downstream fork

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog

TODO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-10-18T11:23:33Z

@swghosh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

bindata/cert-manager-deployment/controller/cert-manager-cluster-view-cr.yaml

thejasn · 2023-10-18T13:18:32Z

bindata/cert-manager-deployment/controller/cert-manager-configmap.yaml

@@ -0,0 +1,12 @@
+apiVersion: v1


Whats the reason upstream for adding this?

Seems like this is one of the new feature additions in cert-manager 1.13, cert-manager/cert-manager#5337 :)

cert-manager deployments would now rely upon a versioned config map implementation like revision controller in our library-go! 😮

This will open up the operand for customisation https://github.com/AcidLeroy/cert-manager/blob/282a6d58a9038a9b54149b8f67fdc1a1a12560cc/deploy/charts/cert-manager/values.yaml#L122-L142 (which we don't want). Since we are ensuring CM exists via the static resource controller, I'm not sure if it also forces the CM to always be empty (hoping it does), Can you verify this?

Our staticresourcecontroller doesn't update the resource, just creation and deletion based upon specific conditions. I can confirm this because I remember that in the past we used a method of adding annotations on a service account added by staticresourcecontroller and there was noticeably no reconciles to undo them. Going through implementation suggests likewise: https://github.com/openshift/library-go/blob/master/pkg/operator/staticresourcecontroller/static_resource_controller.go

However, IMO the user changing this config map manually would open the operand for customization and we don't have a good way to restrict that yet in our current changes.

bindata/cert-manager-deployment/webhook/cert-manager-webhook-deployment.yaml

thejasn · 2023-10-19T11:50:23Z

/lgtm

openshift-ci · 2023-10-19T11:52:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: swghosh, thejasn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [thejasn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 15, 2023

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 15, 2023

openshift-ci bot requested review from chiragkyal and thejasn September 15, 2023 08:44

swghosh changed the title ~~CM-189: Rebase v1.13.0~~ CM-190: Rebase v1.13.0 Sep 15, 2023

swghosh marked this pull request as ready for review September 18, 2023 09:44

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2023

swghosh marked this pull request as draft September 18, 2023 09:44

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2023

openshift-ci bot requested review from s-urbaniak and stlaz September 18, 2023 09:45

swghosh mentioned this pull request Sep 18, 2023

[o/cert-manager-operator] CI job config updates for 1.12, 1.11 openshift/release#43445

Merged

swghosh marked this pull request as ready for review September 20, 2023 09:52

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 20, 2023

swghosh force-pushed the rebase-1.13.0 branch 2 times, most recently from 3313737 to e441fe9 Compare September 20, 2023 14:50

openshift-ci bot requested a review from lunarwhite September 21, 2023 13:08

chiragkyal force-pushed the rebase-1.13.0 branch from 787d537 to c45b71d Compare October 17, 2023 13:11

swghosh commented Oct 17, 2023

View reviewed changes

go.sum Outdated Show resolved Hide resolved

swghosh commented Oct 17, 2023

View reviewed changes

bundle/manifests/cert-manager-operator.clusterserviceversion.yaml Outdated Show resolved Hide resolved

swghosh added 12 commits October 18, 2023 15:45

Bump go dependency cert-manager@v1.13.0

3d2c24e

Signed-off-by: Swarup Ghosh <swghosh@redhat.com>

Bump o/api, o/library-go dependencies go mod

5701642

Signed-off-by: Swarup Ghosh <swghosh@redhat.com>

Bump sig.k8s.io related dependencies

e12f18e

* controller-runtime * controller-tools Signed-off-by: Swarup Ghosh <swghosh@redhat.com>

Bump sig.k8s.io/kustomize/kustomize v4->v5

6e2db6d

* required bump to make bundle work without conflicts Signed-off-by: Swarup Ghosh <swghosh@redhat.com>

Update Makefile: bundle_version, channels, manifest_source url

284d714

* make update-with-container - pull upstream manifests * make update-bindata * make bundle -- this now uses kustomize v5, to fix some conflicts Signed-off-by: Swarup Ghosh <swghosh@redhat.com>

More manual replaces v1.12->v1.13

1f4e3e0

* make bundle Signed-off-by: Swarup Ghosh <swghosh@redhat.com>

Update k8s.io/code-generator deprecated generate-groups.sh to kube_co…

c7b8653

…degen.sh Signed-off-by: Swarup Ghosh <swghosh@redhat.com>

Bump go dependency cert-manager@v1.13.1

a6c33c5

Signed-off-by: Swarup Ghosh <swghosh@redhat.com>

Update Makefile: manifest_source url use v1.13.1

91df426

* make update-with-container * make update-bindata * make bundle Signed-off-by: Swarup Ghosh <swghosh@redhat.com>

More manual replaces v1.13.0->v1.13.1

4444725

- make bundle Signed-off-by: Swarup Ghosh <swghosh@redhat.com>

Update go.sum due to replaces in openshift/jetstack-cert-manager

3981c89

Signed-off-by: Swarup Ghosh <swghosh@redhat.com>

Use skipRange >=1.12.1 <1.13.0, replaces 1.12.1

9e2fd90

Signed-off-by: Swarup Ghosh <swghosh@redhat.com>

swghosh force-pushed the rebase-1.13.0 branch from c45b71d to 9e2fd90 Compare October 18, 2023 10:20

chiragkyal mentioned this pull request Oct 18, 2023

CM-215: add nodeaffinity for non-x86 archs #157

Merged

thejasn reviewed Oct 18, 2023

View reviewed changes

openshift-ci bot assigned thejasn Oct 19, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2023

openshift-ci bot merged commit 6746376 into openshift:master Oct 19, 2023
7 checks passed

CM-190: Rebase v1.13 #143

CM-190: Rebase v1.13 #143

Conversation

swghosh commented Sep 15, 2023 • edited

cert-manager changelog

openshift-ci-robot commented Sep 15, 2023 • edited by openshift-ci bot

cert-manager changelog

openshift-ci bot commented Sep 15, 2023

openshift-ci-robot commented Sep 15, 2023 • edited by openshift-ci bot

cert-manager changelog

swghosh commented Sep 15, 2023

openshift-ci-robot commented Sep 15, 2023 • edited by openshift-ci bot

cert-manager changelog

openshift-ci-robot commented Sep 18, 2023 • edited by openshift-ci bot

cert-manager changelog

openshift-ci-robot commented Sep 18, 2023 • edited by openshift-ci bot

cert-manager changelog

openshift-ci-robot commented Sep 20, 2023 • edited by openshift-ci bot

cert-manager changelog

swghosh commented Sep 20, 2023

openshift-ci-robot commented Sep 20, 2023 • edited by openshift-ci bot

cert-manager changelog

openshift-ci-robot commented Sep 20, 2023 • edited by openshift-ci bot

cert-manager changelog

chiragkyal commented Sep 20, 2023

swghosh commented Sep 21, 2023

openshift-ci-robot commented Oct 9, 2023 • edited by openshift-ci bot

cert-manager changelog

openshift-ci-robot commented Oct 11, 2023 • edited by openshift-ci bot

cert-manager changelog

swghosh commented Oct 17, 2023

swghosh commented Oct 18, 2023 • edited

openshift-ci-robot commented Oct 18, 2023 • edited by openshift-ci bot

cert-manager changelog

openshift-ci bot commented Oct 18, 2023

thejasn Oct 18, 2023

Choose a reason for hiding this comment

swghosh Oct 18, 2023

Choose a reason for hiding this comment

thejasn Oct 18, 2023

Choose a reason for hiding this comment

swghosh Oct 19, 2023

Choose a reason for hiding this comment

thejasn commented Oct 19, 2023

openshift-ci bot commented Oct 19, 2023

swghosh commented Sep 15, 2023 •

edited

openshift-ci-robot commented Sep 15, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Sep 15, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Sep 15, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Sep 18, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Sep 18, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Sep 20, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Sep 20, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Sep 20, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Oct 9, 2023 •

edited by openshift-ci bot

openshift-ci-robot commented Oct 11, 2023 •

edited by openshift-ci bot

swghosh commented Oct 18, 2023 •

edited

openshift-ci-robot commented Oct 18, 2023 •

edited by openshift-ci bot