Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CM-224: Rebase v1.12.1 based on upstream cert-manager v1.12.5 #156

Merged
merged 3 commits into from
Oct 18, 2023
Merged

CM-224: Rebase v1.12.1 based on upstream cert-manager v1.12.5 #156

merged 3 commits into from
Oct 18, 2023

Conversation

swghosh
Copy link
Member

@swghosh swghosh commented Oct 17, 2023 •
edited

[v1.12.5] Rebase Checklist:

  • go dependencies
go get github.com/cert-manager/cert-manager@v1.12.5
go mod tidy
go mod vendor

go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@v1.12.5
go mod tidy
go mod vendor

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog (since v1.12.4)

TODO

@swghosh
Bump go dependency cert-manager@v1.12.5
78e922e 
Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
@swghosh
Update Makefile: bundle_version, manifest_source url
1c9a1ad 
* make update
* make update-bindata
* make bundle

Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
@swghosh
Update skipRange, replaces field in CSV;
34c165d 
More manual replaces
* '1.12.0' -> '1.12.1' (bundle)
* '1.12.4' -> '1.12.5' (operand)

Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 17, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 17, 2023 •
edited by openshift-ci bot

@swghosh: This pull request references CM-224 which is a valid jira issue.

In response to this:

[v1.12.5] Rebase Checklist:

  • go dependencies
go get github.com/cert-manager/cert-manager@v1.12.5
go mod tidy
go mod vendor

go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@v1.12.5
go mod tidy
go mod vendor
  • push commit c975b56caa2f058fed79c6e8554617a647c01e52 to openshift/jetstack-cert-manager release-1.12 branch
  • update bundle description to include upstream version of cert-manager

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog (since v1.12.4)

TODO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@swghosh swghosh changed the title CM-224: Rebase v1.12.1 z-stream based on upstream cert-manager v1.12.5 CM-224: Rebase v1.12.1 based on upstream cert-manager v1.12.5 Oct 17, 2023
@swghosh
Copy link
Member Author

swghosh commented Oct 17, 2023

/cc @thejasn

@swghosh
Copy link
Member Author

swghosh commented Oct 17, 2023

/label docs-approved
self-adding as I've already added doc requirement label on CM-224.

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Oct 17, 2023
@thejasn
Copy link
Contributor

thejasn commented Oct 17, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: swghosh, thejasn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2023
@swghosh
Copy link
Member Author

swghosh commented Oct 17, 2023

/cc @lunarwhite @xingxingxia
for qe-approved label
/cc @davemulford
for px-approved label

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 17, 2023 •
edited by openshift-ci bot

@swghosh: This pull request references CM-224 which is a valid jira issue.

In response to this:

[v1.12.5] Rebase Checklist:

  • go dependencies
go get github.com/cert-manager/cert-manager@v1.12.5
go mod tidy
go mod vendor

go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@v1.12.5
go mod tidy
go mod vendor

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog (since v1.12.4)

TODO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 17, 2023 •
edited by openshift-ci bot

@swghosh: This pull request references CM-224 which is a valid jira issue.

In response to this:

[v1.12.5] Rebase Checklist:

  • go dependencies
go get github.com/cert-manager/cert-manager@v1.12.5
go mod tidy
go mod vendor

go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@v1.12.5
go mod tidy
go mod vendor

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog (since v1.12.4)

TODO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@davemulford
Copy link

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Oct 17, 2023
@xingxingxia
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 18, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 18, 2023 •
edited by openshift-ci bot

@swghosh: This pull request references CM-224 which is a valid jira issue.

In response to this:

[v1.12.5] Rebase Checklist:

  • go dependencies
go get github.com/cert-manager/cert-manager@v1.12.5
go mod tidy
go mod vendor

go mod edit -replace github.com/cert-manager/cert-manager=github.com/openshift/jetstack-cert-manager@v1.12.5
go mod tidy
go mod vendor

Signed-off-by: Swarup Ghosh swghosh@redhat.com

cert-manager changelog (since v1.12.4)

TODO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2023

@swghosh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 6e2b17a into openshift:cert-manager-1.12 Oct 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thejasn thejasn Awaiting requested review from thejasn

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

@TrilokGeer TrilokGeer Awaiting requested review from TrilokGeer

@davemulford davemulford Awaiting requested review from davemulford

@lunarwhite lunarwhite Awaiting requested review from lunarwhite

@xingxingxia xingxingxia Awaiting requested review from xingxingxia

Assignees

@thejasn thejasn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@swghosh @openshift-ci-robot @thejasn @davemulford @xingxingxia